Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][workflows] Centralizing MDX docs on Gatsbyjs.org #14890

Closed
6 tasks done
gillkyle opened this issue Jun 18, 2019 · 9 comments
Closed
6 tasks done

[docs][workflows] Centralizing MDX docs on Gatsbyjs.org #14890

gillkyle opened this issue Jun 18, 2019 · 9 comments
Assignees
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@gillkyle
Copy link
Contributor

gillkyle commented Jun 18, 2019

Part of the Top 25 Learning Workflows initiative. See #13708 for the meta issue that this issue falls under.

Description:

In an effort to centralize docs for MDX under the Gatsbyjs.org docs, all guides should be moved from the gatsby-mdx docs to .org. We should add createRedirects on the gatsby-mdx page as well to point users to Gatsby's docs where documentation will continue for what is now gatsby-plugin-mdx.

The name of the reference guides on MDX has been a question, should "Adding Components to Content with MDX" be changed to something that instead mentions adding JavaScript?

  • add new page in Gatsby API section of the docs sidebar for MDX
  • move docs from gatsby-mdx.netlify.com to .org
  • create redirects from gatsby-mdx.netlify.com to corresponding pages on .org
  • update references to https://gatsby-mdx.netlify.com/ to new docs on .org
  • update references to gatsby-mdx to official plugin gatsby-plugin-mdx
  • clarify docs on using frontmatter and imports in the same file

Related:

#14258

@gillkyle gillkyle added type: documentation An issue or pull request for improving or updating Gatsby's documentation 🎯 Learning labels Jun 18, 2019
@gillkyle gillkyle self-assigned this Jun 18, 2019
@marcysutton
Copy link
Contributor

Here's a relevant comment from the feedback widget on gatsbyjs.org:

I had a problem using MDXProvider with MDXRenderer. The issue was, the gatsby-mdx docs say to import MDXRenderer from '@mdx-js/tag', which silently fails. This doc imports '@mdx-js/react', which works as expected.

@gillkyle
Copy link
Contributor Author

gillkyle commented Jun 19, 2019

Thanks, this is actually something I noticed too and have updated the example from the referred guide 👍

@robinmetral
Copy link
Contributor

Quick aside: it took me a while to understand there were two ways of doing custom components, MDX and Rehype. Since we're trying to encourage MDX, shouldn't we recommend it over Rehype in gatsby-example-using-remark?

@gillkyle
Copy link
Contributor Author

Yeah that's a good point @robinmetral, I know MDX uses rehype and remark internally (see here) so trying to push people towards MDX seems like a good idea there, though I think it's great to have that documentation still the same.

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 16, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 16, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@johno johno added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Jul 16, 2019
@amberleyromo amberleyromo self-assigned this Jul 24, 2019
@lannonbr
Copy link
Contributor

As gatsby-mdx.netlify.com now tells people to use gatsby-plugin-mdx instead, is there any remaining tasks for this issue?

@marcysutton
Copy link
Contributor

There may be–we want to make sure the APIs are fully documented. @amberleyromo is taking that on

@jackbravo
Copy link
Contributor

Seems like this effort is now finished, right? There is this new section: https://www.gatsbyjs.org/docs/mdx/ Should this issue be closed?

@marcysutton
Copy link
Contributor

I checked in with Amberley and Kyle Gill, and it sounds like this one is indeed done now. Any remaining improvements can be handled in new issues and PRs. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests

8 participants