Extra comma and " | Gatsby" in showcase details title

[rosslh]

Description

Showcase details pages have an extra , and | Gatsby in the document <title/>

Steps to reproduce

• Visit https://www.gatsbyjs.org/showcase/www.metaprojection.ca
• Visit https://www.gatsbyjs.org/showcase/reactjs.org

Expected result

• The title should be MetaProjection: Showcase | GatsbyJS
• The title should be ReactJS: Showcase | GatsbyJS

Actual result

• The title is MetaProjection,: Showcase | GatsbyJS | GatsbyJS
• The title is ReactJS,: Showcase | GatsbyJS | GatsbyJS

Environment

Reproduced on:

• OS
  • Kubuntu 16.04
• Browsers
  • Firefox 69.0.02
  • Chrome 77.0.3865.90

[fboechats]

@rosslh How can I reproduce it locally??

[mrkutly]

It looks like this happens when you link directly to a showcase page. If you navigate to any of them from the showcase index, the title is fine. The extra comma only gets added if you go directly to a show page.

Click here to see error: https://www.gatsbyjs.org/showcase/reactjs.org
Click here and navigate to react page to see it behave as expected: https://www.gatsbyjs.org/showcase

Update: Oddly enough, the opposite is true when I run the website locally. Clicking to the page causes the bug, but refreshing or going directly to it works correctly.

I'll keep working on it and try to find a fix for it.

[mrkutly]

Digging around I found at least 2 react Helmet components that were tryin to set the title for each page. Setting the prop titleTemplate="" for the Helmet in the showcase-details.js component did the trick.