Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] gatsby-plugin-sass available #845

Closed
danielfarrell opened this issue Apr 24, 2017 · 3 comments · May be fixed by MaxMood96/gatsby#158
Closed

[1.0] gatsby-plugin-sass available #845

danielfarrell opened this issue Apr 24, 2017 · 3 comments · May be fixed by MaxMood96/gatsby#158

Comments

@danielfarrell
Copy link
Contributor

Not sure what the best way to share this was, but I packaged up some code to handle sass/scss in 1.0 released it:

https://github.com/danielfarrell/gatsby-plugin-sass

npm install gatsby-plugin-sass

If that helps you, have at it. If you want to incorporate it into this repo, let me know.

@KyleAMathews
Copy link
Contributor

Hey this is fantastic! Thanks for putting this together!

I'm not entirely sure what's the best way to differentiate between core and non-core plugins. There'll be 1000s of Gatsby plugins eventually, the vast majority of which won't belong in core (nor could we handle that quantity).

The basic heuristic I've been using is whether the plugin is a) easy to write/maintain and 30%+ of sites would use it b) is it necessary for an example site (example sites dog food the latest changes to core as well as their plugins so all plugins for example sites have to be in this repo) or c) the plugin is a critical for bootstrapping the community early on e.g. all the Markdown plugins I've written.

This Sass plugin does kinda feel like it falls under A. It'll be easy to maintain as the Webpack plugin does 95% of the work and it will be widely used. That being said, if you feel like you'll be committed to maintaining it going forward e.g. quickly tracking core changes, fixing bugs, answering support questions, etc. then I think it'd be fine keeping it outside core. But if not (and there'll actually be a number of breaking changes to the webpack integration soon feel free to PR it here as a package and share the maintenance load with others here).

@ghost
Copy link

ghost commented Apr 24, 2017

@danielfarrell Thanks for Plugin, our team was looking for similar stuff. It would be great if you can provide sample implementation of your plugin in use at your documentation. Best Practice you aware of while using SaSS in gatsby world if it differs from usual react world.

@danielfarrell
Copy link
Contributor Author

Merged into this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants