feat(gatsby-plugin-offline): reload when missing resources and SW was updated + add "onServiceWorkerUpdateReady" API #10432
Conversation
…new API for updates
|
@pieh (summary of what I said on Slack): the current API |
|
@pieh this site https://www.mahmago.com/ is a good example of why we need a separate API - upon first visit it says "this site has updated" |
|
|
||
| return cachedResponse | ||
| }) | ||
| return caches.match(offlineShell, { cacheName }) |
There was a problem hiding this comment.
I don't think it's safe to remove that yet. This handles stuff before runtime actually run, so we can't really rely that any changes we make in runtime are actually in effect (not to mention that people can use "missmatched" versions of gatsby and offline plugin in this could "brick" their sites still in those still not figured out scenarios)
`onServiceWorkerUpdateFound`を使うようにドキュメントに書かれていた。
> ```javascript
> exports.onServiceWorkerUpdateFound = () => {
> const answer = window.confirm(
> `This application has been updated. ` +
> `Reload to display the latest version?`
> )
>
> if (answer === true) {
> window.location.reload()
> }
> }
> ```
>
> https://www.gatsbyjs.org/docs/add-offline-support-with-a-service-worker/
が、これだとページを初めて開いたときにもこの表示が出てしまうので、`onServiceWorkerUpdateReady`というのを追加しようというPull Requestがある。
gatsbyjs/gatsby#10432
これがマージされたらこっちに切り替えよう。
| @@ -34,8 +35,10 @@ | |||
| }, | |||
| "repository": "https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-offline", | |||
| "scripts": { | |||
| "build": "babel src --out-dir . --ignore **/__tests__", | |||
| "build": "npm run build:src && npm run build:sw-append", | |||
| "build:src": "babel src --out-dir . --ignore **/__tests__", | |||
There was a problem hiding this comment.
do we need to ignore sw-append.js here? for builds it probably doesn't matter - it will be overwritten by cpx in next step, but while watching, babel will try to compile it?
There was a problem hiding this comment.
ah yep, that's a good point - need to fix that
Co-Authored-By: davidbailey00 <4248177+davidbailey00@users.noreply.github.com>
vtenfys
changed the title
|
Was testing this over the weekend and it seems like nice improvement - especially part that reloads page if there are missing resources and service worker did update |
|
Just need to bump |
pieh
changed the title
|
Has anyone experieced this "missing recourses" error on a gatsby site without PWA or using |
|
@sgnl Please could you open an issue describing this behaviour if you're still having it? Thanks 🙂 Just a heads up, sometimes it can be caused by adblockers so if you're using one, try disabling it and see if you get the same issue. |
Fixes #10036