Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content): Address lints in gatsby announcement #24543

Closed
wants to merge 1 commit into from
Closed

fix(content): Address lints in gatsby announcement #24543

wants to merge 1 commit into from

Conversation

Eyas
Copy link
Contributor

@Eyas Eyas commented May 27, 2020

Description

These are blocking yarn test for every other PR.

Two lints being addressed:

docs/blog/2020-05-27-announcing-series-b-funding/index.md
  52:507-52:512  warning  Replace `voila` with `voilà`        voila              retext-diacritics
   69:77-69:131  warning  Don’t pad `link` with inner spaces  no-inline-padding  remark-lint

Documentation

N/A

Related Issues

N/A

@Eyas
Address lints in gatsby announcement
bc25485 
These are blocking `yarn test` for every other PR.
@Eyas Eyas requested a review from a team as a code owner May 27, 2020 18:20
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2020
@Eyas Eyas mentioned this pull request May 27, 2020
Merged
@Eyas
Copy link
Contributor Author

Eyas commented May 27, 2020

@mgienow can you review? Since this is related to #24534

@Eyas Eyas changed the title Address lints in gatsby announcement fix(content) Address lints in gatsby announcement May 27, 2020
@Eyas Eyas changed the title fix(content) Address lints in gatsby announcement fix(content): Address lints in gatsby announcement May 27, 2020
@tesseralis
Copy link
Contributor

Resolved: #24556

@tesseralis tesseralis closed this May 28, 2020
@ascorbic ascorbic removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eyas @tesseralis @ascorbic