Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array.IsValueEqual and NotValueEqual #286

Closed
gavv opened this issue Feb 8, 2023 · 2 comments · Fixed by #287
Closed

Add Array.IsValueEqual and NotValueEqual #286

gavv opened this issue Feb 8, 2023 · 2 comments · Fixed by #287
Assignees
@nhAnik
Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Milestone
v2

Comments

@gavv
Copy link
Owner

gavv commented Feb 8, 2023

These two method should work similar to Object.IsValueEqual and NotValueEqual, but accept index instead of key.

New methods should have documentation comments with code examples, and be covered by unit tests.
@gavv gavv added feature New feature or request help wanted Contributions are welcome good first issue Good for newcomers labels Feb 8, 2023
@nhAnik
Copy link
Contributor

nhAnik commented Feb 8, 2023

Hi @gavv , can I work on this?

@gavv
Copy link
Owner Author

gavv commented Feb 8, 2023

Sure, thanks!

@nhAnik nhAnik mentioned this issue Feb 9, 2023
Merged
@gavv gavv closed this as completed in #287 Feb 9, 2023
@gavv gavv added this to the v2 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhAnik nhAnik

Labels
feature New feature or request good first issue Good for newcomers help wanted Contributions are welcome
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Add Array.IsValueEqual and Array.NotValueEqual nhAnik/httpexpect
2 participants
@gavv @nhAnik