From 2ac8d3f48dd3b1803cbb1785423d22af8d7bec65 Mon Sep 17 00:00:00 2001 From: Michael Carroll Date: Wed, 29 Jun 2022 09:22:10 -0700 Subject: [PATCH 1/2] Add .cc extension to suppress CMake warnings (#428) Signed-off-by: Michael Carroll --- src/CMakeLists.txt | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 9751047db..b5817f457 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -16,17 +16,17 @@ set (sources ) set (gtest_sources - Application_TEST - Conversions_TEST - Dialog_TEST - DragDropModel_TEST - Helpers_TEST - GuiEvents_TEST - ign_TEST - MainWindow_TEST - PlottingInterface_TEST - Plugin_TEST - SearchModel_TEST + Application_TEST.cc + Conversions_TEST.cc + Dialog_TEST.cc + DragDropModel_TEST.cc + Helpers_TEST.cc + GuiEvents_TEST.cc + gz_TEST.cc + MainWindow_TEST.cc + PlottingInterface_TEST.cc + Plugin_TEST.cc + SearchModel_TEST.cc ) if (MSVC) From 088712545a9888bc3a7f9789d7f684a094af9988 Mon Sep 17 00:00:00 2001 From: Louise Poubel Date: Thu, 11 Aug 2022 09:41:36 -0700 Subject: [PATCH 2/2] Fix -Wfree-nonheap-object Signed-off-by: Louise Poubel --- src/CMakeLists.txt | 2 +- src/PlottingInterface_TEST.cc | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index b5817f457..e79fb1b01 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -22,7 +22,7 @@ set (gtest_sources DragDropModel_TEST.cc Helpers_TEST.cc GuiEvents_TEST.cc - gz_TEST.cc + ign_TEST.cc MainWindow_TEST.cc PlottingInterface_TEST.cc Plugin_TEST.cc diff --git a/src/PlottingInterface_TEST.cc b/src/PlottingInterface_TEST.cc index 4149e26f7..0237dfedb 100644 --- a/src/PlottingInterface_TEST.cc +++ b/src/PlottingInterface_TEST.cc @@ -172,8 +172,7 @@ TEST(PlottingInterfaceTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(Transport)) auto transport = Transport(); - double time = 10; - std::shared_ptr timeRef(&time); + auto timeRef = std::make_shared(10); transport.Subscribe("/collision_topic", "pose-position-x", 1, timeRef); transport.Subscribe("/collision_topic", "pose-position-z", 1, timeRef);