Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MessageWidget] Repeated field name doesn't handle name changes #29

Closed
osrf-migration opened this issue May 24, 2018 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@osrf-migration
Copy link

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


The feature added on pull request #109 only works nicely if all subsequent messages maintain the number of repetitions, their order and their names. If either of these changes, the collapsible is not renamed and the widget becomes inconsistent.

A failing test case has been added and commented out. Possible solutions I can think of:

  1. Never reuse repeated widgets, always construct them new - this is very expensive computationally
  2. Always check the name and rename the widget if needed - this should be cheaper than Run tests without installing #1 but will still have some impact
@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • Edited issue description

@osrf-migration osrf-migration added minor bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the minor label May 11, 2020
@chapulina
Copy link
Contributor

This refers to ign-gui0, which is no longer under development. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants