-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make global shortcuts either opt-out or configurable #9
Comments
Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina). I worry that creating a configuration for each shortcut could be hard to maintain. On the other hand, a blanket opt-out might not offer enough flexibility and downstream developers will end up having to re-implement all the shortcuts they want. Another alternative I can think of is making the shortcuts easily overridable programatically. Could you give more details about your use-case? For example:
|
Original comment by Andrés Fortier (Bitbucket: andres_fortier). Thanks for looking at this @chapulina ! Those are great questions:
I expect either to see a bigger
Yes, for the first case mentioned above, I envision e.g.
Yes Since you recently worked on making the "Plugins" menu configurable, how do you feel about making all the UI menus configurable via the XML file (i.e. name, action and shortcut)? The only thing that I wouldn't know how to tackle here is the binding to an action, but maybe it is not that hard / there is a standard way of doing it? Just thinking out loud, but I think that would provide single solution across the board for all menus. |
Original report (archived issue) by Andrés Fortier (Bitbucket: andres_fortier).
After merging https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-gui/pull-requests/43 and integrating it with another project, we realized that we may want to use those shortcuts for other actions in the app. After discussing a bit with @caguero and @nkoenig we concluded that it would be nice if either:
The text was updated successfully, but these errors were encountered: