-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List of plugins / features needed for Rviz2 parity #54
Comments
For reference, here's RViz2's features: https://github.com/ros2/rviz/ And ign-rviz's features: |
@Sarath18 , what do you think of creating a wiki page with this info? |
Sure, I'll create a new page for this. I'll try to include the list of features that are missing, and some potential new features that can be integrated in the long run. I start working on some of the features to reduce the gap. |
I have created a new page for Features needed for RViz parity in the wiki. @chapulina @SteveMacenski @ahcorde can you please review it whenever possible? |
I don't see...
For panels, I think there needs to be that default selector panel (the sidebar thing we use to configure / enable the streams) All the rest looks complete to me. Any other third party ones we want to at this juncture suck into ign-rviz or new features we want to add? Now's the time to dream big! Perhaps... (just spit balling)
You also mentioned plotting |
Thanks, @Sarath18 !
About this, I created an issue here: gazebosim/gz-gui#137 |
Thank you all for the review :)
I have added these plugins and their status to the list.
If I understand this correctly, we do have the display plugin config option available in the right sidebar and the plugins can be added by topic/type using the drawer menu. This can be seen here. Please correct me if I am wrong.
+1. We can add new features to IMU plugin like gravity compensation and instead of just visualizing the acceleration values from IMU, we can even visualization roll, pitch, yaw values and other data. These were not part of IMU visualization plugin.
This is a good idea. There are GUI plugins. If we are going ahead with this, we should definitely discuss the UI/UX of the plugin before proceeding with the development.
I agree, but are we going ahead with visualizing non-stamped data?
I want to visualize this data but I am not sure how to proceed. There are 2 ways that I can think of
I had plans to support the following plugins:
I agree with you and we can support these visualization/plugins natively in ign-rviz. I will add all the aforementioned plugin ideas under a new heading Stretch Goals on the feature list page. If you disagree with any of the plugins, we can have a discussion before proceeding. |
Awesome! That is a great idea. Maybe we can do the same thing with |
One more thing, are with going ahead with PointCloud (old version) visualization? Asking this because ign-rviz targets foxy & above, and as far as I know, PointCloud is deprecated from foxy, in favor of PointCloud2. |
Maybe I haven't played enough with this yet, but does that panel have all of the visualization displays active that you can change params on in a compact way? Perhaps this is more of an improvement item than a new development thing. The IMU display shouldn't be computing any new values, just visualizing what comes in. The RPY/acceleration vector seems reasonable. I'm not sure if it would be possible to cleanly display angular velocities. Many cases of GPS will use the nav sat transform to provide a TF tree from UTM to map frame, so you should be able to transform them if that's provided. I don't think there's any other special considerations (not different than any other sensor feed, needs a valid TF to show in map frame) There is a "steering" demo rviz plugin, though I'm not sure how much use it practically gets. I wouldn't bother with PointCloud(1)'s for that reason. |
The list has been added, so I'm closing this. Thanks @Sarath18 ! |
I think this would make a good reference to know what's missing to potentially work through to make ign-rviz feature complete with Rviz.
The text was updated successfully, but these errors were encountered: