Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition::sensors::SensorFactory.CreateSensor(...) returns null in several tests #49

Closed
jacobperron opened this issue Sep 22, 2020 · 5 comments
Labels
📜 blueprint Ignition Blueprint bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome tests Broken or missing tests / testing infra Windows Windows support

Comments

@jacobperron
Copy link

It looks like in several plugin tests, calling ignition::sensors::SensorFactory.CreateSensor(...) without a template type returns null, resulting in several test failures:

https://build.osrfoundation.org/job/ign_sensors-ci-win/80/testReport/

Currently, only seeing these failures on Windows.

@jacobperron jacobperron added bug Something isn't working Windows Windows support labels Sep 22, 2020
@jacobperron jacobperron added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 22, 2020
@jacobperron
Copy link
Author

@chapulina
Copy link
Contributor

It looks like the sensor plugins can't be found:

23: [Err] [D:\Jenkins\workspace\ign_sensors-ci-win\ws\ign-sensors\src\SensorFactory.cc:74] Unable to find sensor plugin path for [ignition-sensors4-air_pressure]
23: [Err] [D:\Jenkins\workspace\ign_sensors-ci-win\ws\ign-sensors\src\SensorFactory.cc:162] Unable to instantiate sensor plugin for [ignition-sensors4-air_pressure]
23: [Err] [SensorFactory.hh:136] Failed to create sensor of type[air_pressure]

On the change to use ign-plugin in #38, it seems that @ahcorde fixed plugin loading on Windows. I haven't looked closely at the fix and don't know if it is backportable. That PR targets Ignition-E.

@jacobperron
Copy link
Author

Also affecting ign-sensors2: https://build.osrfoundation.org/job/ign_sensors-ign-2-win/42

@jacobperron jacobperron added the 📜 blueprint Ignition Blueprint label Sep 22, 2020
@chapulina chapulina added the tests Broken or missing tests / testing infra label Sep 30, 2020
@scpeters
Copy link
Member

this should be fixed by #60

@scpeters
Copy link
Member

fixed by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome tests Broken or missing tests / testing infra Windows Windows support
Projects
None yet
Development

No branches or pull requests

3 participants