Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iDigBio editors to merge GRSciColl entities #292

Closed
marcos-lg opened this issue Jan 27, 2021 · 5 comments
Closed

Allow iDigBio editors to merge GRSciColl entities #292

marcos-lg opened this issue Jan 27, 2021 · 5 comments
Assignees
Labels
GRSciColl Issues related to institutions, collections and staff

Comments

@marcos-lg
Copy link
Contributor

This requires to create an IDIGBIO_GRSCICOLL_EDITOR role

@marcos-lg marcos-lg added the GRSciColl Issues related to institutions, collections and staff label Jan 27, 2021
@marcos-lg marcos-lg self-assigned this Jan 27, 2021
@MattBlissett
Copy link
Member

I haven't followed the discussion on this (i.e. I have no idea what it's about) but wouldn't something like GRSCICOLL_MERGER be a better name for the role? In case someone outside iDigBio needs the permission.

@marcos-lg
Copy link
Contributor Author

Sorry, I should have explained the issue better.

Currently the merging service doesn't allow to merge iDigBio entities and now we were planning to allow it but only for users with the right permissions. It could actually be IDIGBIO_GRSCICOLL_MERGER since this role will only be used for this use case.

Another option can be to extend the scopes of the editors to, for example, add permissions to modify only iDigBio entities (this could be extended in the future to other types of scopes like countries or other things like IH). This option will require more intrusive changes to the current scoping system but it could be a better solution for the long term.

Any thoughts on this? CC: @ManonGros

@ManonGros
Copy link
Contributor

ManonGros commented Jan 27, 2021

Thanks @marcos-lg!
Extending the scopes would be really useful. I can definitely think of a few use cases for country scopes (and maybe IH, especially if they show interest in using our system in the future).
In this context, an iDigBio scope would be great!
How much work would it be?

Otherwise, if we remain on the ides of having a role (instead of the extended scope), then I think "editor" would make more sense than "merger" as we could use this role to allow other potential functions in the future.

@CatChapman
Copy link

Hi all!

Somewhat related, and please forgive me if this is answered elsewhere or if this question is better suited elsewhere.

For the machine tags in iDigBio entries, are these permission-restricted? i.e. can any editor on the Registry modify these tags, or is it restricted to those in a specific (e.g. iDigBio?) group?

I wonder because ideally at some point in the future we would like collections managers to have the option to update their own entries directly on the Registry, but I envision the risk of them modifying, intentionally or otherwise, the recordset tags and breaking functionality. (In addition to, of course, all the other barriers to getting data providers on board with modifying their own data - I foresee myself being the go-to editor for IDB data providers for quite some time. :) )

@marcos-lg
Copy link
Contributor Author

marcos-lg commented Feb 1, 2021

Thanks @CatChapman. Since we're creating a new IDIGBIO_GRSCICOLL_EDITOR role we could use it to only allow users with this role to modify the iDigBio machine tags. Currently only GRSCICOLL_ADMIN users can modify these machine tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GRSciColl Issues related to institutions, collections and staff
Projects
None yet
Development

No branches or pull requests

4 participants