From 5516496480764e91dd02c4921801cc1f123d8769 Mon Sep 17 00:00:00 2001 From: at055612 <22818309+at055612@users.noreply.github.com> Date: Thu, 6 Jun 2024 12:58:25 +0100 Subject: [PATCH 1/3] Empty initial commit on gh-62-meta-id [no ci] From e51f7cfb29762c97534880bddb4b83d109d86d16 Mon Sep 17 00:00:00 2001 From: at055612 <22818309+at055612@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:07:24 +0100 Subject: [PATCH 2/3] gh-62 Add Id attribute to AnyContentComplextType --- event-logging.xsd | 5 ++++ unreleased_changes/20240606_120340_595__62.md | 24 +++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 unreleased_changes/20240606_120340_595__62.md diff --git a/event-logging.xsd b/event-logging.xsd index ddd1e53..a249421 100644 --- a/event-logging.xsd +++ b/event-logging.xsd @@ -710,6 +710,11 @@ Defines the version of data structure specification. + + + An identifier, name or key to distinguish this block of content from others in the document. + + diff --git a/unreleased_changes/20240606_120340_595__62.md b/unreleased_changes/20240606_120340_595__62.md new file mode 100644 index 0000000..b360710 --- /dev/null +++ b/unreleased_changes/20240606_120340_595__62.md @@ -0,0 +1,24 @@ +* Issue **#62** : Add the `Id` attribute to `AnyContentComplextType`, e.g. `Meta/@Id`. This is to distinguish between multiple sibling `Meta` elements. + + +```sh +# ******************************************************************************** +# Issue title: The Meta element could do with some form of ID/key +# Issue link: https://github.com/gchq/event-logging-schema/issues/62 +# ******************************************************************************** + +# ONLY the top line will be included as a change entry in the CHANGELOG. +# The entry should be in GitHub flavour markdown and should be written on a SINGLE +# line with no hard breaks. You can have multiple change files for a single GitHub issue. +# The entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than +# 'Fixed nasty bug'. +# +# Examples of acceptable entries are: +# +# +# * Issue **123** : Fix bug with an associated GitHub issue in this repository +# +# * Issue **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository +# +# * Fix bug with no associated GitHub issue. +``` From 48fa4138983e93407c9241a6bdc5f260d7232bca Mon Sep 17 00:00:00 2001 From: at055612 <22818309+at055612@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:10:02 +0100 Subject: [PATCH 3/3] gh-62 Add annotation text --- event-logging.xsd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/event-logging.xsd b/event-logging.xsd index a249421..2003d3d 100644 --- a/event-logging.xsd +++ b/event-logging.xsd @@ -712,7 +712,7 @@ - An identifier, name or key to distinguish this block of content from others in the document. + An identifier, name or key to distinguish this block of content from others in the document. It can either be globally unqiue, unique within the document or unique within its siblings.