Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sleeper CLI from environment EC2 #2827

Closed
patchwork01 opened this issue Jul 5, 2024 · 1 comment
Closed

Remove Sleeper CLI from environment EC2 #2827

patchwork01 opened this issue Jul 5, 2024 · 1 comment
Assignees

Comments

@patchwork01
Copy link
Collaborator

patchwork01 commented Jul 5, 2024

Background

Split from:

We were using the sleeper builder Docker image to run deployments of Sleeper in the environment EC2 that we deploy with sleeper environment. Now that we have Nix on the environment EC2, that should no longer be necessary.

There's a separate issue to remove the builder image from the CLI, which can be done after this:

Description

We'd like to remove the Sleeper CLI from the environment EC2.

Analysis

The documentation will need to be updated to use Nix in the environment EC2 instead of sleeper builder.

The Sleeper CLI will need to be removed from the cloud-init script for the environment EC2 (at java/cdk-environment/src/main/resources/cloud-init.sh), and from the script to add a user to the environment EC2 (at scripts/cli/environment/scripts/subcommands/adduser.sh).

We'll need to convert the nightly system tests cron job to run in nix-shell instead of a sleeper builder Docker container.

@patchwork01
Copy link
Collaborator Author

patchwork01 commented Jul 8, 2024

This doesn't seem to be possible for now, since we can't use Nix to replace the builder image.

The Nix package for the AWS CLI overwrites the base Python package and environment, so that any Python in the Nix shell has a number of libraries pinned to versions that are specific to the AWS CLI. That means we can't use our own Python code in the Nix shell because the versions conflict with the AWS CLI.

Closing.

@patchwork01 patchwork01 removed this from the 0.24.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant