Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‼️ Require Read after Write: Let's have ZeBadge have status codes. #247

Open
mariobodemann opened this issue May 28, 2024 · 0 comments
Assignees
Labels
🤖 app Related to ZeApp of ZeBadge 🪪 badge Related to the actual badge (hardware, python ...) 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🧑‍🔬 new feature Used to label new features, to be evaluated and worked on.

Comments

@mariobodemann
Copy link
Member

Currently, most commands (except for the reading of settings / files) do not require any kind of response from the badge: ZeApp issues the command ("write image!") but we never know if it actually succeeds. (That's why the mass upload doesn't work: ZeBadge receives all images as one big blob. Instead it should receive one image after another, with a write of a status inbetween)

Please add the requirement that after every write from ZeApp to ZeBadge, a read needs to be happening.

This should be

a) ZeGood! if the command was executed successfully and no more information can be presented to ZeApp / ze caller.
b) ZeGood:123 if the command was executed successfully and needs to tell ZeBadge that 123 was the result. (aka, 123 pixels writen/ 123 loc achieved, etc.)
c) ZeBad! if an error occurred, but we can't know what specifically went wrong.
d) ZeBad:WORDS if an error with a message (WORDS, no newline) happend.

Please update all commands, and the documentation.

@mariobodemann mariobodemann added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🤖 app Related to ZeApp of ZeBadge 🪪 badge Related to the actual badge (hardware, python ...) 📆 pre_droidcon ‼️ Needs to be done before Droicon 2024 labels May 28, 2024
@mariobodemann mariobodemann self-assigned this Jun 18, 2024
@mariobodemann mariobodemann added 🧑‍🔬 new feature Used to label new features, to be evaluated and worked on. and removed 📆 pre_droidcon ‼️ Needs to be done before Droicon 2024 labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 app Related to ZeApp of ZeBadge 🪪 badge Related to the actual badge (hardware, python ...) 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🧑‍🔬 new feature Used to label new features, to be evaluated and worked on.
Projects
None yet
Development

No branches or pull requests

1 participant