Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign EventDetail page. #270

Closed
tasomaniac opened this issue Mar 2, 2015 · 7 comments
Closed

Redesign EventDetail page. #270

tasomaniac opened this issue Mar 2, 2015 · 7 comments
Labels
enhancement
Milestone
Release 2.6

Comments

@tasomaniac
Copy link
Member

Improve the use of card views in EventDetail.
@friedger friedger added the bug label Mar 3, 2015
@friedger friedger mentioned this issue Mar 4, 2015
Closed
@PareshMayani
Copy link
Member

I am working on this issue and have made improvements.

Can you please check the these snaps and let me know if any changes are required?

1st improvement:

Where I have done layout improvements.

screenshot_2015-03-20-00-37-29

2nd improvement:

Where I have removed that resource background from description layout and have used CardView, to make it looks neat and clean. It would also make all the description layouts consistent across the app.

screenshot_2015-03-20-11-55-43

Please let me know if I should commit these improvements and pull the request :)

@tasomaniac
Copy link
Member Author

Can you align the text inside the card and the texts in the header. Thank you. Great work.

@PareshMayani
Copy link
Member

Done.

screenshot_2015-03-21-02-44-30

@PareshMayani PareshMayani mentioned this issue Mar 20, 2015
Merged
@tasomaniac tasomaniac added this to the Release 2.3 milestone Apr 30, 2015
This was referenced Aug 14, 2015
Open
Open
Open
@tasomaniac tasomaniac modified the milestones: Release 2.4, Release 2.3 Dec 16, 2015
@friedger
Copy link
Contributor

friedger commented Jun 3, 2016

Closing this as it is not very actionable.

@friedger friedger closed this as completed Jun 3, 2016
@tasomaniac
Copy link
Member Author

This can be a label for other Event Detail page related issues. Like Event Detail
We have so much thing to do to improve that page.

@friedger
Copy link
Contributor

friedger commented Jun 3, 2016

nice, for the label. I would use component instead of epic.

@tasomaniac
Copy link
Member Author

makes sense. changing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 2.6
Development

No branches or pull requests
3 participants
@tasomaniac @PareshMayani @friedger