Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIlestone: Kanban Board Setup #25

Closed
geekelo opened this issue Nov 29, 2023 · 2 comments
Closed

MIlestone: Kanban Board Setup #25

geekelo opened this issue Nov 29, 2023 · 2 comments

Comments

@geekelo
Copy link
Owner

geekelo commented Nov 29, 2023

Link to Kanban Board: https://github.com/users/geekelo/projects/3
Team size; 5

PICTORIAL REPRESENTATIONS:
1.
Screenshot from 2023-11-29 11-57-46

Screenshot from 2023-11-29 11-58-55

Screenshot from 2023-11-29 11-59-31

@Meltrust
Copy link

Hi,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, FOR WHICH THE LINK DOES NOT WORK. PLEASE ENSURE ITS NOT PRIVATE.

image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@Meltrust
Copy link

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To highlight

  • Pointings are now equal✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@geekelo geekelo closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants