Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate library-preload.js #8

Open
StErMi opened this issue May 10, 2017 · 5 comments
Open

Generate library-preload.js #8

StErMi opened this issue May 10, 2017 · 5 comments

Comments

@StErMi
Copy link

StErMi commented May 10, 2017

I think it could be a good thing to generate a library-preload.js like in grunt-openui5 SAP-archive/grunt-openui5#47

@Kyrodan
Copy link

Kyrodan commented Nov 2, 2017

Are there any news on this issue? Maybe I could implement this and send a PR?

@geekflyer
Copy link
Owner

@Kyrodan I'm actually not working on ui5 anymore and hence I'm very open for someone else to become maintainer of this repo (and the npm package). I can give you collaborator rights to the repo if you want.

@jomaguma
Copy link
Collaborator

jomaguma commented Jun 7, 2018

I fixed the issue in #10.

@cschuff
Copy link
Collaborator

cschuff commented Jun 12, 2018

You can use the SAPUI5 configuration option xx-libraryPreloadFiles to prevent the default request to library-preload.js and make SAPUI5 load the .json file instead.
Will be looking into your pull request as soon as possible.

@jomaguma
Copy link
Collaborator

Thanks for the link, didn't know about that option.
However, I'd like to use the .js files instead since it's the default in newer versions.
I've been invited to contribute and could merge myself now, but I'll leave the PR open for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants