Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Modal.Action types #350

Closed
wcastand opened this issue Jul 27, 2020 · 2 comments
Closed

Error on Modal.Action types #350

wcastand opened this issue Jul 27, 2020 · 2 comments
Assignees
Labels
type: bug Something isn't working

Comments

@wcastand
Copy link
Contributor

Bug report 🐞

Version & Environment

  • Version of vscode: 1.47.2
  • Version of zeit-ui/react: ^1.8.0-canary.7

Expection

i expect no error when i copy/paste the code from the examples

Actual results (or Errors)

I got a typescript error on the example for Modal:

    <Modal open={state} onClose={closeHandler}>
    <Modal.Title>Modal</Modal.Title>
    <Modal.Subtitle>This is a modal</Modal.Subtitle>
    <Modal.Content>
      <p>Some content contained within the modal.</p>
    </Modal.Content>
    <Modal.Action passive onClick={() => setState(false)}>Cancel</Modal.Action>
    <Modal.Action>Submit</Modal.Action>
  </Modal>

the error i get in vscode and the browser:
Screenshot 2020-07-27 at 11 54 35

I'm not sure why but Mocal.Action seems to not have the proper Props passed in the types.

@unix unix self-assigned this Jul 27, 2020
@unix unix added the type: bug Something isn't working label Jul 27, 2020
@unix
Copy link
Member

unix commented Jul 27, 2020

Thanks for the bug report, version v1.8.0-canary.8 is now available.
Any update, please reply to me.

@wcastand
Copy link
Contributor Author

no more error in vscode with the new version. Thanks ! i think we can close this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants