Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlight on Tabs component #653

Closed
1 of 2 tasks
dededavida opened this issue Dec 2, 2021 · 5 comments · Fixed by #658, #696 or #710
Closed
1 of 2 tasks

Add highlight on Tabs component #653

dededavida opened this issue Dec 2, 2021 · 5 comments · Fixed by #658, #696 or #710
Assignees
@unix
Labels
🗒️ Waiting for release Merged, but waiting for next release.

Comments

@dededavida
Copy link

dededavida commented Dec 2, 2021 •
edited
Loading

Feature request 🚀

  • I will create Pull Request
  • It's just a suggestion

Expected

Add highlight on Tabs component

  • Component
Screen.Recording.2021-12-02.at.16.09.51.mov

Programme (Optional)

Others (Optional)
@nikhilgupta58
Copy link
Contributor

I am picking this up...

@nikhilgupta58 nikhilgupta58 mentioned this issue Dec 23, 2021
Merged
2 tasks
@dededavida
Copy link
Author

thanks @nikhilgupta58 ( ͡❛ ͜ʖ ͡❛)👌

@nikhilgupta58
Copy link
Contributor

No issue @daviddossantos

unix added a commit that referenced this issue Jan 11, 2022
@nikhilgupta58 @unix
feature Update tabs-item.tsx (#658)
b463fbe 
* feat(tabs): display hover effect by styles

Add highlight on Tabs component #653

* feat: redesign the render mode for tabs-item

* test(tabs): update snapshots for styles changes

* docs(tabs): append leftSpace attribute

Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
Co-authored-by: unix <unix.bio@gmail.com>
@unix unix added the 🗒️ Waiting for release Merged, but waiting for next release. label Jan 16, 2022
@unix unix self-assigned this Jan 16, 2022
unix added a commit that referenced this issue Jan 16, 2022
@nikhilgupta58 @unix
feature Update tabs-item.tsx (#658)
7f1b5e8 
* feat(tabs): display hover effect by styles

Add highlight on Tabs component #653

* feat: redesign the render mode for tabs-item

* test(tabs): update snapshots for styles changes

* docs(tabs): append leftSpace attribute

Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
Co-authored-by: unix <unix.bio@gmail.com>
unix added a commit that referenced this issue Jan 17, 2022
@nikhilgupta58 @unix
feature Update tabs-item.tsx (#658)
c60988b 
* feat(tabs): display hover effect by styles

Add highlight on Tabs component #653

* feat: redesign the render mode for tabs-item

* test(tabs): update snapshots for styles changes

* docs(tabs): append leftSpace attribute

Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
Co-authored-by: unix <unix.bio@gmail.com>
unix added a commit that referenced this issue Jan 25, 2022
@nikhilgupta58 @unix
feature Update tabs-item.tsx (#658)
3b6abfe 
* feat(tabs): display hover effect by styles

Add highlight on Tabs component #653

* feat: redesign the render mode for tabs-item

* test(tabs): update snapshots for styles changes

* docs(tabs): append leftSpace attribute

Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
Co-authored-by: unix <unix.bio@gmail.com>
@unix unix linked a pull request Jan 30, 2022 that will close this issue
feature Update tabs-item.tsx #658
Merged
2 tasks
@ofekashery
Copy link
Member

@unix See https://emilkowal.ski/ui/tabs.

This was linked to pull requests Feb 1, 2022
feat(tabs): display highlight on tabs when mouse-in #696
Merged
feat(tabs): allow to hide the border when tab is activated #710
Merged
unix added a commit that referenced this issue Feb 5, 2022
@unix @songhn233 @nikhilgupta58
chore: release v2.3.0 (#715)
a346314 
* feat(button-dropdown): add icon config (#630)

* feature Update tabs-item.tsx (#658)

* feat(tabs): display hover effect by styles

Add highlight on Tabs component #653

* feat: redesign the render mode for tabs-item

* test(tabs): update snapshots for styles changes

* docs(tabs): append leftSpace attribute

Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
Co-authored-by: unix <unix.bio@gmail.com>

* feat: add scale to password component (#685)

* feat: add scale to password component

* chore: update lib name for geist icons

* fix(tabs): fix type of left-space to match component input (#686)

* fix(tabs): fix type of left-space to match component input

* docs: improve header styles to follow tabs component

* feat(page): add props to control the style of dot (#687)

* docs: remove customization tab (#688)

* feat(image): allow component to render svg string (#692)

* feat(image): allow component to render svg string

* docs(image): update the image content of examples

* feat: export use-scale hooks (#693)

* chore: rename scaleable to scale

* docs: separate hooks as a tab to display more information

* docs: update document content to match the hooks section

* docs: refactor the component structure of the documentation site

* docs: skip title format when on hooks page

* fix(tabs): fix sub-components ignore theme changes (#694)

* docs: fix the layout of the document site (#695)

* feat(tabs): display highlight on tabs when mouse-in (#696)

* feat(use-classes): add tool to handle class name strings

* feat(highlight): add component follows the position of the current component

* feat(tabs): display highlight on tabs when mouse-in

* docs(tabs): append props

* test: fix paths for testcase

* fix(styles): optimize font-size for code block (#697)

* feat(code): add props for title text and optimize the styles (#698)

* feat(code): add props for title text and optimize the styles

* docs: extract the code block used for documentation into the components

* docs: redesign documentation styles (#699)

* docs: redesign documentation styles

* docs: remove underline from home tab

* fix(tabs): fix class names be accidentally add to all children

* docs: customize separate styles for instalation page (#700)

* chore: release v2.3.0-rc.0 (#701)

* fix: export use-scale hook and types in the entry

* fix(links): keep links consistent across typography (#703)

* fix(links): keep links consistent across typography

* docs: update hybrid-link to follow the geist component

* feat(button): slightly reduce the default width (#704)

* refactor: remove unnecessary filter for scale props (#705)

* docs: optimize the determination and rendering of relative url (#706)

* docs: fix tabs layout of install page (#707)

* feat(toast): redesign hooks to compatible with placement and styles (#708)

* feat(toast): redesign hooks to compatible with placement and styles

* docs: update APIs of Toast component

* feat(toast): slightly resize the action buttons to fit the overall layout

* fix(toast): restore the timer after remove the element from the stack top

* feat: remove the extra spaces in class-name (#709)

* feat: remove the extra spaces in class-name

* feat(button-dropdown): adjust the minimum width to follow the button component

* docs: add min font-size for documents that use the scale

* feat(tabs): allow to hide the border when tab is activated (#710)

* feat(tabs): allow to hide the border when tab is activated

* docs: remove style overrides from document sites for tabs

* docs: connect hooks with the component example page

* docs: add documentation for use-classes

* chore: release v2.3.0-rc.1 (#711)

* docs: add global search and text indexing (#712)

* feat(highlight): allow highlighting blocks to move laterally

* chore: add additional types for layout utils

* fix(keyboard): fix the ignore to trigger multiple keys at the same time

* docs: add global search and text indexing

* test: update snapshots

* docs: search with local data instead of algolia

* build(package): normalize the names of all commands

* chore: remove now-build

* chore: release v2.3.0 (#714)

* chore: release v2.3.0

* chore: resolve unexpected ring dependencies

Co-authored-by: Songhn <songhn233@gmail.com>
Co-authored-by: Nikhil kumar gupta <36965562+nikhilgupta58@users.noreply.github.com>
Co-authored-by: nikhilgupta58 <nikhil@tartanhq.com>
@unix
Copy link
Member

unix commented Feb 8, 2022

Implemented in version 2.3.0.

@unix unix closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unix unix

Labels
🗒️ Waiting for release Merged, but waiting for next release.
Projects
None yet
Milestone
No milestone
4 participants
@unix @ofekashery @nikhilgupta58 @dededavida