Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): add role="button" to tab for a11y #308

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Jul 2, 2020

Checklist

  • Fix linting errors
  • Label has been added

Change information

Add role="button" to tabs, vercel style has the role attribute. This also make vimium recognize the tab.

image

By the way, what does the "Label has been added" checkbox mean?

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2373     2373           
  Branches      568      568           
=======================================
  Hits         2372     2372           
  Misses          1        1           
Impacted Files Coverage Δ
components/tabs/tabs.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51e158...f28a607. Read the comment docs.

@unix unix added the type: bug Something isn't working label Jul 2, 2020
Copy link
Member

@unix unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🎉
"label" means the label of PR, it was originally used for internal development, but now it seems unnecessary. I will improve the content of the pull-request template.

@unix unix merged commit eaada29 into geist-org:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants