Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(use-body-scroll): add scrollbar width to the container after scrollbar disabled #757

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

unix
Copy link
Member

@unix unix commented Mar 18, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

@unix unix self-assigned this Mar 18, 2022
@netlify
Copy link

netlify bot commented Mar 18, 2022

✔️ Deploy Preview for geist-ui ready!

🔨 Explore the source changes: 8bb3216

🔍 Inspect the deploy log: https://app.netlify.com/sites/geist-ui/deploys/6234a3acb2c3150008ea4325

😎 Browse the preview: https://deploy-preview-757--geist-ui.netlify.app

@unix unix added the type: bug Something isn't working label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #757 (8dc5133) into master (2787229) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8dc5133 differs from pull request most recent head 8bb3216. Consider uploading reports for the commit 8bb3216 to get more accurate results

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      198           
  Lines        3045     3046    +1     
  Branches      669      668    -1     
=======================================
+ Hits         3010     3011    +1     
  Misses         34       34           
  Partials        1        1           
Impacted Files Coverage Δ
components/drawer/drawer.tsx 100.00% <100.00%> (ø)
components/modal/modal.tsx 100.00% <100.00%> (ø)
components/use-body-scroll/use-body-scroll.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2787229...8bb3216. Read the comment docs.

@unix unix merged commit 2abcb36 into geist-org:master Mar 18, 2022
@unix unix deleted the fix/scrollbar branch March 18, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant