Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go linting #1705

Merged
merged 53 commits into from
Sep 13, 2023
Merged

add go linting #1705

merged 53 commits into from
Sep 13, 2023

Conversation

k0l11
Copy link
Collaborator

@k0l11 k0l11 commented Sep 12, 2023 •
edited
Loading

closes #1226

  • some linters are commented out (either impractical or highly controversial)
  • exhaustruct should be enabled in a later PR
  • includes significant fix for dori: after-sales rounds attacks never occurred before

k0l11 added 30 commits September 11, 2023 21:29
@k0l11
add linters and vscode settings from srsim
a0c2ff7 
- all linters initially disabled
@k0l11
adjust lint to exclude wasm cli
80a3501 
- syscall/js is not available in every build env
@k0l11
format vscode settings
12ad613
@k0l11
enable gosimple linter
5551a6d
@k0l11
enable govet linter
77ac52c
@k0l11
enable ineffassign linter
6674976
@k0l11
delete scripts that are not needed
06e84ae
@k0l11
enable staticcheck linter
d24af70
@k0l11
enable typecheck linter
0ac9a8f
@k0l11
add .gitattributes for linting just in case
2279b80
@k0l11
add gofmt linter
ec87e13
@k0l11
add goimports linter
5429da3
@k0l11
add stylecheck linter
8be5d6c 
- ignore Id -> ID issue
@k0l11
add gocritic linter
eaeb104
@k0l11
add whitespace linter
a8a4991
@k0l11
add nolintlint linter
036fb62
@k0l11
add errname linter
c8bd597
@k0l11
add nonamedreturns linter
ea8dc51
@k0l11
add revive linter
1bf075a
@k0l11
add tagalign linter
85adda8
@k0l11
add tagliatelle linter
2accf11
@k0l11
add nestif linter
5674ddd
@k0l11
add asasalint linter
6af6381
@k0l11
add bidichk linter
ce3bfc7
@k0l11
add unused linter
44141cc
@k0l11
add dogsled linter
5ec0472
@k0l11
add errorlint linter
f765ece
@k0l11
add errchkjson linter
a7bb1dd
@k0l11
add exportloopref linter
c042fa0
@k0l11
add makezero linter
62d5730
@k0l11 k0l11 added kind: enhancement New feature or request area: devops related to the development/build process labels Sep 12, 2023
@k0l11 k0l11 marked this pull request as ready for review September 12, 2023 20:45
unleashurgeek
unleashurgeek previously approved these changes Sep 12, 2023
View reviewed changes
.vscode/settings.json Show resolved Hide resolved
unleashurgeek
unleashurgeek previously approved these changes Sep 12, 2023
View reviewed changes
unleashurgeek
unleashurgeek previously approved these changes Sep 12, 2023
View reviewed changes
@k0l11 k0l11 marked this pull request as draft September 12, 2023 22:55
@k0l11 k0l11 marked this pull request as ready for review September 13, 2023 00:05
@k0l11 k0l11 merged commit 5cdc47e into genshinsim:main Sep 13, 2023
@k0l11 k0l11 deleted the add-linters branch September 13, 2023 00:09
@k0l11 k0l11 mentioned this pull request Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unleashurgeek unleashurgeek unleashurgeek approved these changes

Assignees
No one assigned
Labels
area: devops related to the development/build process kind: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add linting to Go backend
2 participants
@k0l11 @unleashurgeek