Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sortby dps and create date options #1709

Merged
merged 8 commits into from
Sep 17, 2023
Merged

Added sortby dps and create date options #1709

merged 8 commits into from
Sep 17, 2023

Conversation

ChinPTeo
Copy link
Contributor

@ChinPTeo ChinPTeo commented Sep 17, 2023 •
edited
Loading

many changes because srl doesn't have prettier installed :smadge:

k0l11
k0l11 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@k0l11 k0l11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for missing some translations on the page in general ("Tags", "Date Added", "Sort By")

@k0l11 k0l11 added kind: enhancement New feature or request area: web Related to the web app labels Sep 17, 2023
@k0l11 k0l11 merged commit 49b2959 into genshinsim:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0l11 k0l11 k0l11 approved these changes

Assignees
No one assigned
Labels
area: web Related to the web app kind: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChinPTeo @k0l11