Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeclared Jinja2 dependency #1030

Open
craigds opened this issue Oct 6, 2024 · 3 comments · May be fixed by #1031
Open

Undeclared Jinja2 dependency #1030

craigds opened this issue Oct 6, 2024 · 3 comments · May be fixed by #1031

Comments

@craigds
Copy link
Contributor

craigds commented Oct 6, 2024

Description

pycsw depends on jinja2 for some reason, and this isn't declared in requirements.txt

Environment

  • operating system: mac/linux
  • Python version: 3.10
  • pycsw version: master (c532be3)

Steps to Reproduce

>>> from pycsw import server
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/cdestigter/code/pycsw/pycsw/server.py", line 48, in <module>
    from pycsw.ogc.api.util import yaml_load
  File "/Users/cdestigter/code/pycsw/pycsw/ogc/api/util.py", line 45, in <module>
    from jinja2 import Environment, FileSystemLoader
ModuleNotFoundError: No module named 'jinja2'
craigds added a commit to koordinates/pycsw that referenced this issue Oct 6, 2024
@craigds
Add missing jinja2 dependency causing ModuleNotFoundError
1e9acc5 
Fixes geopython#1030
@craigds craigds linked a pull request Oct 6, 2024 that will close this issue
Open
1 task
@kalxas
Copy link
Member

kalxas commented Oct 6, 2024

Jinja is pulled in by https://github.com/geopython/pycsw/blob/master/requirements-standalone.txt

@craigds
Copy link
Contributor Author

craigds commented Oct 6, 2024

hm, confusing; I hadn't considered looking in a nonstandard location for this (and, grepping didn't find it)

I suppose that's fine except that things pycsw actually imports directly should probably be mentioned explicitly there, rather than pulled in as a side-effect of some other dependency

@craigds
Copy link
Contributor Author

craigds commented Oct 6, 2024

changed my PR to pull it in explicitly in requirements-standalone.txt. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly add jinja2 dependency koordinates/pycsw
2 participants
@craigds @kalxas