Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag value type divergence #106

Open
geospatial-jeff opened this issue Jan 3, 2021 · 1 comment
Open

fix tag value type divergence #106

geospatial-jeff opened this issue Jan 3, 2021 · 1 comment

Comments

@geospatial-jeff
Copy link
Owner

Tag values are currently typed as Union[Any, Tuple[Any]]. This causes lots of downstream issues because the type is unclear. It would make the code much cleaner if we removed the Union and only used a single type for tag values. This would also let us add mypy to pre-commit.
@geospatial-jeff geospatial-jeff mentioned this issue Jan 3, 2021
Merged
@geospatial-jeff
Copy link
Owner Author

This is also kind of related to #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geospatial-jeff