Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open time in exchange_calendar_xkrx.py #337

Closed
nballen-tx opened this issue Sep 28, 2023 · 1 comment
Closed

open time in exchange_calendar_xkrx.py #337

nballen-tx opened this issue Sep 28, 2023 · 1 comment

Comments

@nballen-tx
Copy link

Hi,

the open time is specified as following in code row #41-42

Open Time: 9:00 AM, KST (Korean Standard Time)
Close Time: 3:30 PM, KST (Korean Standard Time)

however the code has

open_times = (
    (None, time(9, 30)),
    (pd.Timestamp("1978-04-01"), time(10, 0)),
    (pd.Timestamp("1986-04-01"), time(9, 40)),
    (pd.Timestamp("1995-01-01"), time(9, 30)),
    (pd.Timestamp("1998-12-07"), time(9, 0)),
)

Looks like a typo.

Thanks,

@maread99
Copy link
Collaborator

@nballen-tx, thanks for the comment.

The code is saying that the usual opening time was 09:30 until "1978-04-01" from when it was 10:00 until "1986-04-01" from when it was 09:40, etc.

Since "1998-12-07" the usual open time has been 09:00, hence this being the time stated in the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants