Skip to content

Commit

Permalink
Remove "Rgraphviz" from special packages #8
Browse files Browse the repository at this point in the history
  • Loading branch information
chainsawriot committed Mar 5, 2023
1 parent 7551685 commit 23b3fc6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion R/resolve.R
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
if (isTRUE(no_enhances)) {
disabled_types <- c(disabled_types, "Enhances")
}
res <- dep_df[!dep_df$type %in% disabled_types & dep_df$y != "R" & !(dep_df$y %in% c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools", "grid", "splines", "Rgraphviz", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial")),]
res <- dep_df[!dep_df$type %in% disabled_types & dep_df$y != "R" & !(dep_df$y %in% c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools", "grid", "splines", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial")),]
if (nrow(res) == 0) {
return(NULL)
}
Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/test_resolve.R
Original file line number Diff line number Diff line change
Expand Up @@ -310,3 +310,10 @@ test_that("issue 102 confusion between github and local pkgref", {
expect_equal(.parse_pkgref(unique(graph$ranglets[[1]]$original$x_pkgref), FALSE), "local")
setwd(original_wd)
})

test_that("Rgraphviz", {
skip_if_offline()
skip_on_cran()
x <- resolve("bioc::biocGraph", snapshot_date = "2023-01-01")
expect_true("bioc::Rgraphviz" %in% names(x$ranglets[[1]]$deps))
})

0 comments on commit 23b3fc6

Please sign in to comment.