From 23b3fc6cef0c98ea4d5c378e6724dc6591a7c38c Mon Sep 17 00:00:00 2001
From: chainsawriot <chainsawtiney@gmail.com>
Date: Sun, 5 Mar 2023 13:42:52 +0100
Subject: [PATCH] Remove "Rgraphviz" from special packages #8

---
 R/resolve.R                   | 2 +-
 tests/testthat/test_resolve.R | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/R/resolve.R b/R/resolve.R
index ef1ccde..50191cd 100644
--- a/R/resolve.R
+++ b/R/resolve.R
@@ -214,7 +214,7 @@
     if (isTRUE(no_enhances)) {
         disabled_types <- c(disabled_types, "Enhances")
     }
-    res <- dep_df[!dep_df$type %in% disabled_types & dep_df$y != "R" & !(dep_df$y %in% c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools", "grid", "splines", "Rgraphviz", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial")),]
+    res <- dep_df[!dep_df$type %in% disabled_types & dep_df$y != "R" & !(dep_df$y %in% c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools", "grid", "splines", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial")),]
     if (nrow(res) == 0) {
         return(NULL)
     }
diff --git a/tests/testthat/test_resolve.R b/tests/testthat/test_resolve.R
index 6948720..ba5f416 100644
--- a/tests/testthat/test_resolve.R
+++ b/tests/testthat/test_resolve.R
@@ -310,3 +310,10 @@ test_that("issue 102 confusion between github and local pkgref", {
     expect_equal(.parse_pkgref(unique(graph$ranglets[[1]]$original$x_pkgref), FALSE), "local")
     setwd(original_wd)
 })
+
+test_that("Rgraphviz", {
+    skip_if_offline()
+    skip_on_cran()
+    x <- resolve("bioc::biocGraph", snapshot_date = "2023-01-01")
+    expect_true("bioc::Rgraphviz" %in% names(x$ranglets[[1]]$deps))
+})