From ee44b6b2fc6cec880732389f3c7bb715b4dc264f Mon Sep 17 00:00:00 2001 From: chainsawriot Date: Wed, 14 Jun 2023 10:51:10 +0200 Subject: [PATCH 1/2] Add `base` to special packages, fix #144 Also ref #8 --- R/resolve.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/resolve.R b/R/resolve.R index d67fc4e..90902a2 100644 --- a/R/resolve.R +++ b/R/resolve.R @@ -228,7 +228,7 @@ dep_df$y != "R" & !(dep_df$y %in% c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools", "grid", "splines", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial", - "eda", "lqs", "mle", "modreg", "mva", "stepfun", "ts")),] + "eda", "lqs", "mle", "modreg", "mva", "stepfun", "ts", "base")),] if (nrow(res) == 0) { return(NULL) } From d28b527efd109a2a6f6452de3ce018e5baa08baf Mon Sep 17 00:00:00 2001 From: chainsawriot Date: Wed, 14 Jun 2023 11:07:42 +0200 Subject: [PATCH 2/2] Add test case for #144 --- tests/testdata/dt.RDS | Bin 0 -> 6899 bytes tests/testthat/test_expost_rang.R | 5 +++++ 2 files changed, 5 insertions(+) create mode 100644 tests/testdata/dt.RDS diff --git a/tests/testdata/dt.RDS b/tests/testdata/dt.RDS new file mode 100644 index 0000000000000000000000000000000000000000..8d2838f4cfa0301765e32405be6c6a337f21c529 GIT binary patch literal 6899 zcmV`$-ScZf>DisR z+vRRp?U|M1REF%T?CPA!%FN5m>ggU3h64}ro1mW*1rZSrKlld-BZ3IJpm59f`DH(d z2cqYBp1a<9cROZQ#fyyhG9oLhtFo#(y9Rn9->b;T`0?J07cXAC_|j^jP*^S$mxKRH z!DFHH?!C`#To0fZ0wDac%>K?5iiMRRU3&fX@P7eQbTz9(a1~egZ1X@59zP9opzO}W zju)iQ3AmM8y4SjA+one{U+^r=@%C;1ep~Z(^44mz-rU@%U)^YI4ZgGVLjTu6a`m; zYFjrJ;A}uHb6(l}@uwlr<|EBe=ENqG1$u!V1HFW(Yi;M&oA2Ct(=>DosI=s_O#dOM zP`~>5n|I)coto=845<3L=llB_yj9%QJRLH6zUD&(&h5Y(9anSqjTV>D9ru=gV6=2V zRJyvqZ?^#~-nn`AE|l2w4c?^Uu5J7Lode&p-7fs3A3FSbr{zFxS6$EVwGCTy3@GvT zp~e|=xns5=XQ2IQHDB8`p*3Y!*V>0Bl)CTxE|l@e@b_KG=a$}hi}Z8#Zm-h`dd!;; zT)Cw?y46kzzTI_f*FQ7h$`=jmp<#9I*>MCOmUBNp{Gs|wzj%4GRv&^M|n21Y*wZRXfOjsSD1j)cMiSl8cy@#a)dsUDX>{U@>R9I=a zBqBX70v5}V3j;KkBV431k#mHCkF%2ZebBIsq?>8TlMS^$+hK=&onj zR)lbRyF%7#fOyz(^*wm?2;`-I{@%^M z+Rn5VWc;h}T4~}#o^s$;o{@2SR*2gv)^lJ-SeGddrvMmpseiN{gp2ok(lJV5pK#j%KN038Iyx?8wWadbK)9v{Gk$jDNvxB z6d!5zr1!^AJ|(&=Ly2U@6f%L>m=YL~9D7S7Jf@6d@{?-2>}8P@S$!!%vez+LQpFwX z2&YgjjA87QQN9rJ*5CAsUQ3N*Pnz#J>4`zl8Uc5 z&n5=<3Rgagt)2^u^Xdc7w#-Pb7Q055s||KA!+RcNUD~ zRj4P4Cd2{p=1w>HZXvFlEKgB)SdNJ#{DgD$7ubyi02*-o`9Jvmr{U5Vrx`YYlC&De z??nqqDlQ%O$R(MHxEv;P;I)Cwk;xcRymT!h=Z8VoxplJLXI9P8fD=VXSTK8ULm zuwy;aQZonmI4%9ruWg6@JzkpOI7z3&`9~6B)4YdH=qkwAQq)3;v?#ZYP$I!_p_w|S zFj5Wnfz7w=%AVaedR8W|C$S)p-}=uyc!l3eW* z#*2LgMlE;q#QzrJ^Tg5=pznhC(i;-?wSP?-#?_dVGc1&s%Avor;e9qI2dt5%lu$)P1S1)i7cj*cHBJI z)jF;bi6gvUTz#bPitg>_c4%d0ydlfy4u!3*+FvM*cBo?T&Q^SRMZLY?Yw6ZhN+~X% zsFO`~WYlCEt1KrOLB1Q5zj;7ry<0m)9#?Dd5;~qS9}uo#-$SW62LKH6@h8`Q;c2)d zJlQnEL6)7wIsG`?M!pNa+6p9NkgucjX~s8pqhm? z*A8S0H%mhe=gCVt>AWEk5XjqzY)92a+jy$EZnM_lTd%~IXe;hZ#Jdi=6|fU$v4Ljv zfreXsZcZ5bk$11;6RpJaUnGom@OuFA$la{?Q6WAnR_18dtHf9|YZ!kwm`R%Av@#I@ zy7_}^N8f!CZpn?7X4uV?;O7C0Yq-4M<%bX)SNHv+ULXSi6*-cXgHnz-qlgFR74riA z%yisP@i)h`EI~1B3o7cTOVFXTx2V4wlg6m$;zxT^2-N(^$xjNWLr!9{pDYxUj8{a# zHW2_i_V~TS-`oy0?a|T5L=OnJNC+(Y(z^9PqBCPgst>TNov+0*|8aA&4Eq(HjWX~$($jzw%d<@E8`&P*D zW2PC7L2Ml`djzSVY3%8(qZYUP5cOpxV4jw3?HSS8L*cwR@;JZ>>x$Xibq#@q%Z_21 zno6W8Jj-Wu5>c^JrP_z8a}7FxSL?OSgkyt)HzJ30)rJ+5zjSn@dJ@Y^M@kYOK;p?D z(|6(HWCU4OG>-Wf|FS)+7iS&&cm~tTi!z=+a{%d!dhKeod_HRc=Y{89dhj%)z4=Tt zG;|Kd8qBWYUj;W36qNzZh^4k;9&z2Jqg%Qg zMF~P%pjgeR1e1@j4>ojvlx(^_(#*Ea0Wk<||5!Zx#$#PGP1`5^GQkiJvvwhx9*nzi zpqyPH%Gy@kRSERKO$4Vpb_fw6Vtd6(XD8(*a;SZZK`mhCcoThUNH8ue;K&v-TSi2T z#_RzCyD1b`wK6I)pfVl>Vn+6&$dVAg3p1u(9t6FEIr~*C~XG1WMcs&0-T2`FRwfeY4dcY8S+rfoU=eo z7qNtfgDdFBXHa={0dWvTfyIykoI2aB?E76)^y*m)5s!>^N9Sq=z6=3tIK+!FblVRK z_h5cqa(E$$*Ceb2+JpVTjqYI@?hc8~^bm>BwpQiE;y*`HWKQMM* zoz#U97y8A8Hv1d(dL1D{OL&0X9QQ+5q>>ea#Dz80O%VxR$cWFC_IJwj3{5%zQiR6* zufCZA%L1uGZghG?lnd;ngF`-%;{FOi6L~S3->=L@&u~bNPGV62 zCZrdSU?f+$tTee_Nn9J|L@-nvR(X^R(S?~V$+;!22d6fPOVwJLn@DmfH<7Q>E1>M- zn9~yM;Ic~+`@EMsJ@wm#xSm>^fxcLT&Y|x0BO!2E{o4~Z(*n@;543N5GianL&9Lo? z0|sNFNuQ_!%+N_{t!;RY?S)rnd!&ppV*o%gDGq#Wl2=m2OOcC(OR%gLT9rF){-K1M z^LQ0w%-Q&?AaFO7L}%F31^{&)|KsxSZHJyv(@is^PK9so0)28c?%-i(5s+Ob;k1FM zwU$i7N*`biFX2{vqkR<0a$W(^_$yn{;r7f^@U^UiOyi3pMQ8g&m;YE;wo%qtqr`#Z ziz~%dktuxhC1#9~JnluZTmw$9P8R%4wi>z!I83zY76XJ*E|K!5LCG$Rd}-G9`59_l zFM-?=V+EdVfOJe48*+02aE-T%cxwBD~u7#f8aa*EP6@ zy67gL*g+_@^_I;Ygxb2-0)oL#!pa?mvT5&n!hS-`yGM)+8Ph<^UQkEwXOI-+F(IO` zS`~#ZnjdxXw8OYx=fpMtWL`H!tchI26kCCpB#t*Jb|1hmU*NG-Kygl!I_0O@lVEBv z;=mz3H6k}ERBpHhROHOGK}1uAgFbs2_`et88u)9o)~ruknt^Wfnsj>vnbCa1=XBKhVrxq|mSJ*}>w)_cg)qkeDs@ zbr*gTqR_?;G2x4dXza>TxSHaNF6*eZXBwS--)n%Wup0E~ZqG2=P>TRIZ4JPZ({o+r zE*y(Mpp4=k?q~?!lF>OOpppp&>za!Qstb6wFs3fLiAisc8h!=iAjfrS%rO)JH+DN! z?1vM3rLOi5a!sbVOxOY9 z*@iVc8Wx+2)S=_Zyu`fn;g0EwTzi&gTax$!xaH$5@=x zqCj`T%*M(U=eOjbA9$`y4CNutdpWlb{&OL29ej1x*0xh@)q53QLb7WC%^Jd^Q)<+1 zaJ69pOatJerTmwFzuh$hg(9lB-lofp(lML@?y{5gL^}gOgMs0 zEyQQ6wDsLyrwb(yvBC_ux+Ggus+MNizQI2yGpMXPn%UJ|N4GjX!%FEsLJcWi&pj{# z%^ct%9wow!Tjhhcv9~8Ry1)J+&OuGbHP%> zOucq3!43i47F%LVED__xd0z!90vB(i*%btV7mJ$7mZVttjj;G1ZJD2bvCdY-L`ntv(RAi3e*J4q{q}aycPC6U?CZFMn-vDvOL`nl^c+U#%o2n3C0H7+i~zXaJlP z0GN*3#&`N8A*O4YR3vNTahR$RTS`P@qh9~FV`OjvD8mYMKT zWzfapu6c18%3Cr_sY_g3rjV*|3lQp6Y(mVRQ2nG37phBB5SF|Q+}#|+x%!$_0|QXk z_y2Z%uP9mSvM>NJC8Lh>gkukNZh=btv{m2>>p|doFA=lDj>Z z4U?BxzWdyw#m z-zha~S9w&$p#Ze;`28;*ZHIG)Jk79;E8rT_J_&-f9o^2*aW!Y(XmMeyH|p1bcZ+7% z?vl4p=97lYNVC2qL9Zo|?@7&BMzQ{kV+XCs9UscVT`y0O|CSMzsGf1&_+UpCV;L$a03+Y3}$6z)o@%*FR>Tc*at z`l0!XuDQ|K5XZF-L4a3UX3z8ahDxPtqOhWtrE@pmpq_2J`#Iay`BkDN*U?-6Dt80G z)9(QF9E#S0@*T~04VZC?cW&Oj3(uaZbxF$?$0|sN%*n}txTXRXlq>PcTj(P7N>rO9 z!-3=&fJoIB-~%FULwTkoQ~r6dNC@=LaEJ@ow*_8cm;p!R zPLumiVZJO4NDvMM@Vn)DZEK@>Z3Kv09sb<-&#--pG{g2v807>gvi6rQm&hfSyBc|G zq|imGE4NZPF_P~NT~8%kHyE}ecRVSxI?R<5;_X9?moNr^OI_aNXWT}9EIG zL%vOyX76|?wmLJE%JGoe9hK5xCA^INu5BK0!+gKsTLGbx!Y3HtEZGlw=~C=?t9zTCj>=jqwfE4UwEWTGwiSU zMKW1nh+dvx1F!mqb>v5;y|Q7MhQ%E$-M)!1WI|w$fS$i#_`Yt@k7Q(CChM$GkD~`< z5H3|wA!+TYAgpi?F#{&*ClKkhx1wmV&}X?5P_p&PJm@(^{m|)-{EW+})N40x+}OA_ z7RVKw@2ub14rNSonx*Q;cG#jukB`A$z?)k{?wsFw(>87Q4Of2@ZL@iMUf1APft7Z; z&K^}@Cgq$u0rf?;c_Ec1Z0|(UVu&(?+RcOyYklrygiMJ!3!W>O9r6p2J?lp8%ElHy zKXrCMPS~$}wfQ6@u-T>=61GeZE^sHs5f2B&aS>_?EOuOj-?w6FzHhX6EKlX81M)W! zru6fJs@$>LI?qeoSW5lx1JxKJRPAbx7?+>S>Pw!(E9SIyhsp~wzh`!v%TQI}wzaQW zk$1-QVB+p{vdx$&JdlCI)?cY2B)9)UM9heS*~^%Y)9n>0y+;K4eqLlaMCDS)m9<^N zZn0WpmPK^WLn9&Tmuh%bhIB~N2K3gSb* z=Dhqg9J0x#84kTvBIOB*o6FUX)i3C-b+>EVK6ic_U%L8)ws9~SGk^}@h^$G zNz7R{y^BPtweQ*%spynKjGRQjAoDrYm>xgPZf53vglA@Eo{SA_eCB)}k%&0R5MhQ6 zb$lvU__~hc4g%Xg19HgSZ23`PzI;9^-2>mU-R@{0@hNT8nj6iu0B`f|;tXjS9E!{N^=tvNOlUDW--x3_4SH7~4y2zrV6j-P* z#upj^=goOja>uCi>eNx(4W#TMz>U+9OgS7AO7@zh3y}bX20Vhw0wLF z*+xj^_$g{o(X}ke+Z>5t+Fg#M6SgW5z$RS7dTz%oVcF^3?ZZT%o2Q;;VRT|%axlV=JA z(AEZ%bp7nO-leVnHB}f{+^jXO5#0ISZqM?28_i(;+ajI43h#yYCByKtu}P$Xbma5A tKn(-xi}ps2JXilpbP9ybMdw4)Gr=v{Dsn1@RSpO7{{g_~11LEx0RS-bgXaJM literal 0 HcmV?d00001 diff --git a/tests/testthat/test_expost_rang.R b/tests/testthat/test_expost_rang.R index 2d33006..3b84396 100644 --- a/tests/testthat/test_expost_rang.R +++ b/tests/testthat/test_expost_rang.R @@ -185,3 +185,8 @@ test_that("Super ancient special packages", { graph <- readRDS("../testdata/superancientsna.RDS") expect_error(.generate_installation_order(graph), NA) }) + +test_that("base as a dependency, issue 144", { + graph <- readRDS("../testdata/dt.RDS") + expect_error(.generate_installation_order(graph), NA) +})