Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local:: #57

Closed
chainsawriot opened this issue Feb 16, 2023 · 3 comments
Closed

Support local:: #57

chainsawriot opened this issue Feb 16, 2023 · 3 comments
Assignees
Labels

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Feb 16, 2023

I would say all ingredients are there already. But we need to give warnings

  • when local:: is used for resolve(), remind users that this is not reproducible on another machine where the local package is not available.
  • When dockerize(), enforce cache and transfer the local packages in the raw tarball format (don't R CMD build locally, do it inside the container, like how we treat GitHub packages now).

Tag v0.2 for now. But don't know how tedious it can be.

@chainsawriot chainsawriot changed the title Support for local:: Support local:: Feb 16, 2023
@chainsawriot
Copy link
Collaborator Author

@chainsawriot chainsawriot self-assigned this Feb 19, 2023
@chainsawriot
Copy link
Collaborator Author

27-02: I will work on this first, to complete the entire implementation of pkgrefs.

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Feb 28, 2023

  • parse and resolve
  • sessionInfo
  • renv (read)
  • dockerize (enforce cache)
  • Does the container work?
  • .write_rang_as_comment adds a comment that rang with local packages is not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant