Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.generate_installation_order can be in an infinite loop #81

Closed
chainsawriot opened this issue Feb 24, 2023 · 2 comments
Closed

.generate_installation_order can be in an infinite loop #81

chainsawriot opened this issue Feb 24, 2023 · 2 comments
Assignees
@chainsawriot
Labels
bug Something isn't working

Comments

@chainsawriot
Copy link
Collaborator

Mostly due to #8 , .generate_installation_order can be in an infinite loop.

Of course, we need to find out those special packages.

On another hand, we need to count the number of loops and fail after maybe length(needed_pkgrefs) loops.

The latest panic is bioc::Organism.dplyr.
@chainsawriot chainsawriot added the bug Something isn't working label Feb 24, 2023
@chainsawriot
Copy link
Collaborator Author

This loop

https://github.com/chainsawriot/rang/blob/e1b7b971a0e9f5e532f0528653cb818ba31fa17f/R/installation.R#L55-L66

@chainsawriot chainsawriot self-assigned this Feb 24, 2023
@chainsawriot
Copy link
Collaborator Author

#38

This was referenced Feb 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chainsawriot chainsawriot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chainsawriot