Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode invoice fails if invoice does not have expiry #132

Closed
rolznz opened this issue Dec 28, 2023 · 0 comments · Fixed by #134
Closed

decode invoice fails if invoice does not have expiry #132

rolznz opened this issue Dec 28, 2023 · 0 comments · Fixed by #134
Assignees
@rolznz

Comments

@rolznz
Copy link
Contributor

rolznz commented Dec 28, 2023 •
edited
Loading

e.g. lnbc1u1pjc65cpsp5s0ug8ef4ftz7shgcrg9u32p26yfnss2jvn8lf5ef3dnfs3whj04qpp5u4rd3pf5nuj683ycqs95yxhhxtf0ydt36prvq9ntq54mhqvxax8qdqdg9kxy7fq2ph4xcqzysrzjqtypret4hcklglvtfrdt85l3exc0dctdp4qttmtcy5es3lpt6utsmlnye9rpnzdxcgqqqqqqqqqqqqqqyg9qxpqysgqafjchml7d6zfp7u7mjtcasxzp5pglvpejelazshdfgnzdqw030upmtul2luhqdjvkdcf483u5l5ratu8dk0ffr38ypx9aqk57d7vwfcq3xutqa

Also error handling is not good in that function. Can it be improved?
@rolznz rolznz self-assigned this Dec 28, 2023
@rolznz rolznz mentioned this issue Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolznz rolznz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: invoice expiry getAlby/js-lightning-tools
1 participant
@rolznz