[BUG] alby:image meta tag gets overridden by favicon

[jankoegel]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

• on www.jan-koegel.de I have set <meta property="alby:image" content="https://ik.imagekit.io/jankoegel/img/photos/heidelberg-graffiti-underpass.jpg?tr=w-500,e-sharpen">
• when I visit the page and open my Alby extension I see my favicon and not the image from the alby:image meta tag.

Favicon (actual)

alby:image (expected)

Screenshots [optional]

Steps To Reproduce

1. visit www.jan-koegel.de
2. open the Alby extension
3. see the favicon instead of the alby:image

Expected behavior

Alby information

1.18.0
getAlby wallet
installed via app store

Device information

OSX, Firefox

Additional context

• https://getalby.slack.com/archives/C02TD6P5XPE/p1668084403378329

PR giving prevalence to metadata.icon (favicon) over metadata.image (alby:image)

• style: prefer website icon over image #959
• the metadata.icon rules actually start with alby:image:
  

  lightning-browser-extension/src/extension/content-script/originData.ts

  Lines 599 to 604 in 16dff6a

  	icon: {
  	rules: [
  	[
  	'meta[property="alby:image"][content]',
  	(element) => element.getAttribute("content"),
  	],

  
  but as far as I understand the code calling the rules, they get processed one after the other and later ones take precedence (unless the scorer function intervenes):
  

  lightning-browser-extension/src/extension/content-script/originData.ts

  Lines 677 to 699 in 16dff6a

  	for (let currRule = 0; currRule < ruleSet.rules.length; currRule++) {
  	const [query, handler] = ruleSet.rules[currRule];
  	const elements = Array.from(doc.querySelectorAll(query));
  	if (elements.length) {
  	for (const element of elements) {
  	let score = ruleSet.rules.length - currRule;
  	if (ruleSet.scorer) {
  	const newScore = ruleSet.scorer(element, score);
  	if (newScore) {
  	score = newScore;
  	}
  	}
  	if (score > maxScore) {
  	maxScore = score;
  	value = handler(element);
  	}
  	}
  	}
  	}

Are you working on this?

No

[jankoegel]

👍 working for me now.