Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Text should be inside the field #2061

Closed
1 task done
bitcoinuser opened this issue Feb 4, 2023 · 10 comments
Closed
1 task done

[BUG] Text should be inside the field #2061

bitcoinuser opened this issue Feb 4, 2023 · 10 comments
Labels
good first issue Good for newcomers later question Further information is requested

Comments

@bitcoinuser
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The text on send window should be inside the field, like the receive window.

Screenshots [optional]

Send window with text outside the field:

Captura de tela de 2023-02-04 10-48-04

Should be like receive window with text inside the field:

Captura de tela de 2023-02-04 10-48-17

Steps To Reproduce

1- Go to send window

Expected behavior

See the text inside the field, like the receive window.

Alby information

Alby: 1.25.1

Device information

No response

Additional context

No response

Are you working on this?

No

@bumi bumi assigned im-adithya and unassigned im-adithya Feb 4, 2023
@bumi bumi added the good first issue Good for newcomers label Feb 4, 2023
@escapedcat
Copy link
Contributor

This current result was done on purpose because of #1517

Placeholders are made to display input examples, not as a replacement for labels or hints I believe.
In that case the hint-text (used as a placeholder displayed inside the input) was too long and gets cut off in some languages.

Might be better to check the extension and align this behaviour?
wdyt @reneaaron @jankoegel @jakubszwedo

@escapedcat escapedcat added the question Further information is requested label Feb 5, 2023
@bitcoinuser
Copy link
Contributor Author

I don't care the text be cut. Why not mouseover on text and see the full text?

@escapedcat
Copy link
Contributor

Why do you dislike the hint-text below the input?

I don't care the text be cut.

We need to consider more users though.

Why not mouseover on text and see the full text?

Not very accessible. We should try to find a better way to handle this.

@stackingsaunter
Copy link
Contributor

I agree with @escapedcat on this - the consensus is to to use a placeholder only to show examples of the input, MAYBE some hints, but as far as I research it's also advised to show them outside, especially if they are convening some important info - otherwise leave it empty. There shouldn't be any crucial information in there, which in the case of Send and types of input we can paste here, is quite important, so I'd leave it outside. We have a lot of space below so we can easily display the hint below the input.

We could think of taking hints out of the input in the case of Receive screen. I think it's less crucial here, as the hints do not show any new information to the user, and are just a little helper. One could argue "amount in satoshis" does, but we use satoshis all over the extension, so it's not really new and we display fiat value all the time.

@bitcoinuser
Copy link
Contributor Author

What about this idea?

video_2023-02-24_11-46-24.mp4

@bitcoinuser
Copy link
Contributor Author

I agree with @escapedcat on this - the consensus is to to use a placeholder only to show examples of the input, MAYBE some hints, but as far as I research it's also advised to show them outside, especially if they are convening some important info - otherwise leave it empty. There shouldn't be any crucial information in there, which in the case of Send and types of input we can paste here, is quite important, so I'd leave it outside. We have a lot of space below so we can easily display the hint below the input.

We could think of taking hints out of the input in the case of Receive screen. I think it's less crucial here, as the hints do not show any new information to the user, and are just a little helper. One could argue "amount in satoshis" does, but we use satoshis all over the extension, so it's not really new and we display fiat value all the time.

What I don't like is the font size. Is very small compared to other windows.

@bitcoinuser
Copy link
Contributor Author

Why do you dislike the hint-text below the input?

I don't dislike it, I dislike the font size that is very small compared to others windows.

@escapedcat
Copy link
Contributor

What about this idea?

This will lead to same issues. A label should be a short precise text to "label" the input. Not an lengthy explanation.

What I don't like is the font size. Is very small compared to other windows.
I don't dislike it, I dislike the font size that is very small compared to others windows.

In this case we could just think about updating the style of that hint-text I guess.
The smaller size should just somehow show that this is not normal text but belongs to the input.
@stackingsaunter you got an idea what could be done here?

@stackingsaunter
Copy link
Contributor

@escapedcat 12px for under-input text is quite common, I think this is the most common size for that thext, eg. Material Design uses precisely 12px. I think bigger font there will be disctracting
Screenshot 2023-03-02 at 12 51 40

The only way to make it bigger is to take this text out and use normal paragraph, but hmm I don't think that looks better?

Screenshot 2023-03-02 at 12 53 31

@escapedcat
Copy link
Contributor

12px for under-input text is quite common, I think this is the most common size for that thext, eg. Material Design uses precisely 12px.

Agreed, that's why I styled it this way. This seems common practice to me.

I don't think this is urgent. We could leave it for now and see if we get any further feedback in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers later question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants