Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #305

Closed
bumi opened this issue Oct 23, 2021 · 7 comments · Fixed by #360
Closed

Dark mode #305

bumi opened this issue Oct 23, 2021 · 7 comments · Fixed by #360
Labels
enhancement New feature or request

Comments

@bumi
Copy link
Collaborator

bumi commented Oct 23, 2021

I heard people like dark modes
Can we use the system's dark/light mode?

@bumi bumi added enhancement New feature or request design labels Oct 23, 2021
@secondl1ght
Copy link
Contributor

Do you know how you want this implemented? If so I could do some research and start working on it.

@secondl1ght
Copy link
Contributor

I did some research on this and it looks like Tailwinds makes this fairly easy. I'll look into implementing it.

@secondl1ght
Copy link
Contributor

Question: I am starting to implement this on this screen first src/app/screens/Onboard/ChooseConnector/index.tsx but I dont see in this file where the styling for the main page comes from. I see styling for some elements on the page and I know I need to go to component files for other elements but where is the styling for the main page coming from. For example the background color of the entire page for this screen?

@bumi
Copy link
Collaborator Author

bumi commented Nov 4, 2021

I think @dylancom can help here.
but I think if it is too much changes or too complicated we should do that later.

@secondl1ght
Copy link
Contributor

Shouldn't be too complicated, I just need to add a dark mode styling for each element. Because I am new to the project I just don't know where to find all the elements that's all.

But if it is decided to be lower priority I can work on something else too. I did start making some changes though and the dark mode does look pretty good.

@bumi
Copy link
Collaborator Author

bumi commented Nov 4, 2021

up to you. :) I just don't think we should too many potential breaking changes at this moment.
but a (WIP) PR would be awesome then we can discuss there.

@secondl1ght
Copy link
Contributor

Ok I started an initial draft here #360.

@dylancom dylancom linked a pull request Dec 1, 2021 that will close this issue
@bumi bumi closed this as completed in #360 Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants