Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webextension-polyfill: 0.8.0 → 0.9.0 (major) #768

Closed
wants to merge 3 commits into from
Closed

Upgrade webextension-polyfill: 0.8.0 → 0.9.0 (major) #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0989aec
Update webextension-polyfill to version 0.9.0
depfu[bot] Apr 25, 2022
83e75db
chore: support webextension-polyfill-0.9.0
escapedcat May 4, 2022
a87efce
chore: adjust TS eslint rules
escapedcat May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
},
"rules": {
"react/prop-types": "off",
"@typescript-eslint/no-unused-vars":["warn", { "args": "none" }] // No warnings for unused function arguments, which might be used in the future.
"@typescript-eslint/no-unused-vars":["warn", { "args": "none" }], // No warnings for unused function arguments, which might be used in the future.
"@typescript-eslint/ban-ts-comment": ["off", {"ts-ignore": "allow-with-description"}]
},
"settings": {
"react": {
Expand Down
7 changes: 7 additions & 0 deletions jest.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// avoid "This script should only be loaded in a browser extension." issue
// https://github.com/clarkbw/jest-webextension-mock/issues/149#issuecomment-1116307310
// @ts-ignore: chrome available during tests via jest-webextension-mock
if (!chrome.runtime) chrome.runtime = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually sure were chrome is coming from during the tests. I assume via web-extension-mock but not sure how to satisfy TS here.

// @ts-ignore: chrome available during tests via jest-webextension-mock
if (!chrome.runtime.id) chrome.runtime.id = "history-delete";

// jest-dom adds custom jest matchers for asserting on DOM nodes.
// allows you to do things like:
// expect(element).toHaveTextContent(/react/i)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"stream": "^0.0.2",
"tailwindcss": "^3.0.24",
"uuid": "^8.3.2",
"webextension-polyfill": "^0.8.0",
"webextension-polyfill": "^0.9.0",
"zustand": "^3.7.2"
},
"devDependencies": {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17192,10 +17192,10 @@ web-namespaces@^1.0.0:
resolved "https://registry.npmjs.org/web-namespaces/-/web-namespaces-1.1.4.tgz"
integrity sha512-wYxSGajtmoP4WxfejAPIr4l0fVh+jeMXZb08wNc0tMg6xsfZXj3cECqIK0G7ZAqUq0PP8WlMDtaOGVBTAWztNw==

webextension-polyfill@^0.8.0:
version "0.8.0"
resolved "https://registry.yarnpkg.com/webextension-polyfill/-/webextension-polyfill-0.8.0.tgz#f80e9f4b7f81820c420abd6ffbebfa838c60e041"
integrity sha512-a19+DzlT6Kp9/UI+mF9XQopeZ+n2ussjhxHJ4/pmIGge9ijCDz7Gn93mNnjpZAk95T4Tae8iHZ6sSf869txqiQ==
webextension-polyfill@^0.9.0:
version "0.9.0"
resolved "https://registry.yarnpkg.com/webextension-polyfill/-/webextension-polyfill-0.9.0.tgz#de6c1941d0ef1b0858b20e9c7b46bbc042c5a960"
integrity sha512-LTtHb0yR49xa9irkstDxba4GATDAcDw3ncnFH9RImoFwDlW47U95ME5sn5IiQX2ghfaECaf6xyXM8yvClIBkkw==

webidl-conversions@^5.0.0:
version "5.0.0"
Expand Down