Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Replace globals $block_lab_attributes and $block_lab_config #425

Closed
kienstra opened this issue Sep 11, 2019 · 1 comment · Fixed by #435
Closed

Replace globals $block_lab_attributes and $block_lab_config #425

kienstra opened this issue Sep 11, 2019 · 1 comment · Fixed by #435

Comments

@kienstra
Copy link
Collaborator

kienstra commented Sep 11, 2019

The globals $block_lab_attributes and $block_lab_config are used in the class Loader and in helpers.php.

It'd be best to not use globals, and instead move them into an OOP structure.

At the moment, there aren't any references to those globals, when searching WordPress plugins for them on https://wpdirectory.net/

If we're going to replace them, it'd be good to do that soon, before other plugins or themes use them.

@kienstra
Copy link
Collaborator Author

Ah, it looks like this issue is a duplicate of #240

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant