Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav doesn't error when URL is a file #1713

Closed
jacobm001 opened this issue Oct 23, 2017 · 6 comments
Closed

Grav doesn't error when URL is a file #1713

jacobm001 opened this issue Oct 23, 2017 · 6 comments

Comments

@jacobm001
Copy link

jacobm001 commented Oct 23, 2017

I came across this question on StackOverflow and was able to replicate it on my own Grav install. It appears that Grav will not throw a 404 and the error page as it should when the url contains a file. For example:

https://website.com/doesnotexist     -> goes to the error page
https://website.com/doesnotexist.zip -> goes to the homepage.

I'm using apache, and it appears the person who asked the original question is as well.

@nned
Copy link

nned commented Oct 23, 2017

@jacobm001 I confirm this. For sure, it is a nasty bug.

@rhukster rhukster added the bug label Oct 23, 2017
@rhukster
Copy link
Member

Going to look at this...

@rhukster
Copy link
Member

Easy fix! Ready for next release.

@rhukster
Copy link
Member

d3695b2

@jacobm001
Copy link
Author

Thanks!

@Chouchen
Copy link

Thanks for making an issue out of my question on Stackoverflow :)

I thought it was a bad config on my part!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants