-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support Chapters that are not in a comic book file #215
Comments
Thanks for the suggestion! This looks like a nice workaround for #118 as a proper fix would likely take longer. Will work on this when I have the time. |
Supporting directories as chapters sounds really neat to make Mango more compatible with other technologies. One thing of note would be that it needs to check subdirectories rather they contain deeper structures(zips/folders)(current behaviour), or supported image files(added new behaviour). So it can't just assume that any folder on the 2nd level is a chapter.
|
I think we can treat a directory that has images and another entries and titles together as both a title and an entry of its parent title for going easy implementation. Then, we don't need to check if a directory has only images when scanning. (the responsibility of configuring a library is up to the library owners)
For example with above tree:
What do you think? By the way, we would have to define an interface for general entry, since current |
@Leeingnyo yes I was thinking about this as well and I agree this would be the most elegant solution. For the |
I'm not 100% sure that it's an issue from the pr, or an issue in general, but when the folder changes over time(for example, I stream new pages into the folder), mango only seems to consider the pages it found the first scan. |
@tr7zw thank you for reporting! If there are files added, the signature of directory should be changed. I'll check it soon! |
Now, a few hours later I can confirm that it doesn't seem to fix itself, but after creating a copy of the folder it seems to have fixed all folders. Maybe the logic to recalculate this data is not called during a "Scan Library Files", or it's some caching issue? |
@tr7zw that was a bug that the mango didn't notice that the directory had more image files (it detected archive files only). I fixed it in an above PR. Thank you |
Hi there! The feature has been added in v0.27.0. Thanks for the feature request! |
Is your feature request related to a problem? Please describe.
I am running Mango on a VPS that has a limited amount of storage, but I have 1TB OneDrive, so I mounted it with
rclone
and changed thedocker-compose.yml
:version: '3' services: mango: image: hkalexling/mango container_name: mango ports: - 9005:9000 volumes: - ./mango:/root/mango - ./config/mango:/root/.config/mango + - /mnt/onedrive/manga:/root/mango/library
After I did this, the website became really slow and scanning a single manga with 2 Chapters (few MBs) took 27300ms to scan, which seems to be caused by #118.
It seems like
rclone
is downloading the entire library for mango, which is quite expensive and kinda defeats the purpose of storing them in the cloud.Describe the solution you'd like
Currently, Mango only supports libraries that look like this:
Instead of having the chapters in zip files, one should be able to store them in directories:
This should prevent
rclone
from downloading every single zip in the library, just to generate the preview images.It might be good to abstract away the zip under an interface, so directories and comic book files are treated in the same way.
This would have the benefit that comic book files that contain the chapters as directories would be supported as well.
The text was updated successfully, but these errors were encountered: