Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_extensions introduced as prod dependency where it should not have been #8289

Closed
jvdmr opened this issue Nov 4, 2024 · 1 comment · Fixed by #8290
Closed

typing_extensions introduced as prod dependency where it should not have been #8289

jvdmr opened this issue Nov 4, 2024 · 1 comment · Fixed by #8290

Comments

@jvdmr
Copy link
Contributor

jvdmr commented Nov 4, 2024

A recent commit made typing_extensions a required module, which now causes (our) tests to fail because this module is not installed by us, and moto also does not pull it in as a dependency:
E ModuleNotFoundError: No module named 'typing_extensions'

Current workaround is to install the typing_extensions module ourselves, but obviously this should be fixed at the source.

The offending line is this one:

from typing_extensions import TypeAlias

@bblommers
Copy link
Collaborator

Thanks again for providing a fix @jvdmr! We've just released a new version, so this should be solved with moto==5.0.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants