Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Shopify checkout from cart #45

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Conversation

NWRichmond
Copy link
Contributor

WHY are these changes introduced?

Addresses LD-1236

Add @nacelle/shopify-checkout to reference store

Before this PR, clicking the cart's Checkout button didn't create a checkout.

WHAT is this pull request doing?

Adds Shopify checkout functionality from @nacelle/shopify-checkout.

How to Test

Demonstration

Creating a checkout

demo-reference-store-checkout.mov

A completed checkout clears the cart

demo-reference-store-checkout-completed.mov

@vercel
Copy link

vercel bot commented Oct 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nacelle/nuxt-reference-store/DM6FRtDvWQJwrn1rFTnhkchgfBtB
✅ Preview: https://nuxt-reference-store-git-ld-1236-checkout-from-cart-nacelle.vercel.app

Copy link
Contributor

@jasonredick jasonredick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

Not a needed change, but I wonder if we should prevent cart actions from happening while isCheckingOut is true, things like adding a cross sell to the cart or removing an item from the cart.

@NWRichmond
Copy link
Contributor Author

NWRichmond commented Oct 19, 2021

...I wonder if we should prevent cart actions from happening while isCheckingOut is true, things like adding a cross sell to the cart or removing an item from the cart.

Good idea, @jasonredick! Implemented in 9e0507f:

demo-block-cart-actions-while-checking-out.mov

@NWRichmond NWRichmond merged commit 787de79 into main Oct 20, 2021
@NWRichmond NWRichmond deleted the LD-1236-checkout-from-cart branch October 20, 2021 13:08
@github-actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants