From 63a4d4609d9cc0d6667f611384158695acc4b925 Mon Sep 17 00:00:00 2001 From: Jan Kaniewski Date: Mon, 15 May 2023 09:14:25 +0200 Subject: [PATCH 1/2] Std::move --- Source/SocketIOLib/Public/sio_message.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/SocketIOLib/Public/sio_message.h b/Source/SocketIOLib/Public/sio_message.h index 53dc2202..a7c25d41 100644 --- a/Source/SocketIOLib/Public/sio_message.h +++ b/Source/SocketIOLib/Public/sio_message.h @@ -205,7 +205,7 @@ namespace sio } string_message(std::string&& v) - :message(flag_string),_v(move(v)) + :message(flag_string),_v(std::move(v)) { } public: From 62c68c1dbbaa718f8b1efcb72fda8e9a4f95f670 Mon Sep 17 00:00:00 2001 From: Manuel Otheo Date: Sun, 28 May 2023 12:58:39 -0600 Subject: [PATCH 2/2] added missing std::move (#377) --- .../Private/internal/sio_client_impl.cpp | 2 +- Source/SocketIOLib/Public/sio_message.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Source/SocketIOLib/Private/internal/sio_client_impl.cpp b/Source/SocketIOLib/Private/internal/sio_client_impl.cpp index 06cf3498..e73efe9b 100644 --- a/Source/SocketIOLib/Private/internal/sio_client_impl.cpp +++ b/Source/SocketIOLib/Private/internal/sio_client_impl.cpp @@ -129,7 +129,7 @@ namespace sio string query_str_value = encode_query_string(it->second); query_str.append(query_str_value); } - m_query_string = move(query_str); + m_query_string = std::move(query_str); m_http_headers = headers; m_auth = auth; diff --git a/Source/SocketIOLib/Public/sio_message.h b/Source/SocketIOLib/Public/sio_message.h index a7c25d41..9502712b 100644 --- a/Source/SocketIOLib/Public/sio_message.h +++ b/Source/SocketIOLib/Public/sio_message.h @@ -216,7 +216,7 @@ namespace sio static message::ptr create(std::string&& v) { - return ptr(new string_message(move(v))); + return ptr(new string_message(std::move(v))); } std::string const& get_string() const @@ -270,7 +270,7 @@ namespace sio void push(std::string&& text) { - _v.push_back(string_message::create(move(text))); + _v.push_back(string_message::create(std::move(text))); } void push(std::shared_ptr const& binary) @@ -297,7 +297,7 @@ namespace sio void insert(size_t pos,std::string&& text) { - _v.insert(_v.begin()+pos, string_message::create(move(text))); + _v.insert(_v.begin()+pos, string_message::create(std::move(text))); } void insert(size_t pos,std::shared_ptr const& binary) @@ -362,7 +362,7 @@ namespace sio void insert(const std::string & key,std::string&& text) { - _v[key] = string_message::create(move(text)); + _v[key] = string_message::create(std::move(text)); } void insert(const std::string & key,std::shared_ptr const& binary) @@ -462,7 +462,7 @@ namespace sio list(std::string&& text) { - m_vector.push_back(string_message::create(move(text))); + m_vector.push_back(string_message::create(std::move(text))); } list(std::shared_ptr const& binary) @@ -490,7 +490,7 @@ namespace sio void push(std::string&& text) { - m_vector.push_back(string_message::create(move(text))); + m_vector.push_back(string_message::create(std::move(text))); } void push(std::shared_ptr const& binary) @@ -517,7 +517,7 @@ namespace sio void insert(size_t pos,std::string&& text) { - m_vector.insert(m_vector.begin()+pos, string_message::create(move(text))); + m_vector.insert(m_vector.begin()+pos, string_message::create(std::move(text))); } void insert(size_t pos,std::shared_ptr const& binary)