-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom instance name and "Mark as finalized" checkbox #5416
Comments
@grzesiek2010 there's still some acceptance to write up here - we need to think about admin settings for the new button setup. |
Hey @seadowg, I was just chatting with @grzesiek2010, and he pointed out that the confirmation dialog isn't part of this story. I remember discussing it when we were breaking this down, but it's not in the acceptance criteria. Perhaps it was an oversight because there isn't another issue with the dialog in it. The last screen in the finalization flow is the dialog, where they "save as draft" or "finalize" to create some friction/ force the user to confirm to prevent any mistakes. Right now, the acceptance criteria says the flow ends on this page. |
The dialog gets added in #5418. I felt like we didn't need the dialog until we actually removed the ability to edit finalized forms. |
So what about those |
Acceptance
New buttons/layout
Given I've navigated to the end of a form
Then I don't see the instance name field
And I don't see the "Mark form as finalized" checkbox
And I don't see the "Save form and Exit" button
And I don't see the "You are at the end of <form name> text"
Given I've navigated to the end of a form
Then I see text reading "You are at the end of <instance name>"
Given I've navigated to the end of a new form
When I click "Finalize"
Then I am returned to the main menu
And there is a new saved form in Edit Saved Form and Send Finalized Form
Given I've navigated to the end of a form
When I click "Save as draft"
Then I am returned to the main menu
And there is a new saved form in Edit Saved Form
And there is not a new saved form in Send Finalized Form
Updated admin settings
Given I'm in Form Management settings for a project
Then I no longer see the "Default to finalized" setting
Given I'm in Access Control settings for a project
Then I no longer see the "Default to finalized" setting in User Settings
Given I'm in Access Control settings for a project
Then I no longer see the "Mark form as finalized" setting in Form Entry Settings
Given I'm in Access Control settings for a project
When I navigate to Form Entry Settings
And I toggle off "Finalize"
And navigate to the end of a form
Then the "Finalize" button is disabled
Given I'm in Access Control settings for a project
When I navigate to Form Entry Settings
And I toggle off "Save as draft"
And navigate to the end of a form
Then the "Save as draft" button is disabled
Given I've scanned an old QR code
And "Default to finalized" in Form Entry was toggled off when the code was generated
And "Mark form as finalized" was disabled in Access Control (under Form Entry Settings) when the code was generated
When I go to Form Entry Settings in Access Control
Then "Finalize" is disabled
Given I've scanned an old QR code
And "Default to finalized" in Form Entry was toggled on when the code was generated
And "Mark form as finalized" was disabled in Access Control (under Form Entry Settings) when the code was generated
When I go to Form Entry Settings in Access Control
Then "Save as draft" is disabled
Given I've upgraded the app
And "Default to finalized" in Form Entry was toggled off
And "Mark form as finalized" was disabled in Access Control (under Form Entry Settings)
When I go to Form Entry Settings in Access Control
Then "Finalize" is disabled
Given I've upgraded the app
And "Default to finalized" in Form Entry was toggled on
And "Mark form as finalized" was disabled in Access Control (under Form Entry Settings)
When I go to Form Entry Settings in Access Control
Then "Save as draft" is disabled
Given I'm in Access Control settings for a project
When I navigate to Form Entry Settings
And I toggle off "Save as draft"
Then the "Finalize" setting is disabled (I can't toggle it)
Given I'm in Access Control settings for a project
When I navigate to Form Entry Settings
And I toggle off "Finalize"
Then the "Save as draft" setting is disabled (I can't toggle it)
Notes
The "Save as Draft" button won't make a lot of sense when editing a finalized form. How this behaves is up to the implementer as we'll remove the ability to get into the situation instead of smoothing it out.
This is based on the proposed changes from https://forum.getodk.org/t/collect-form-finalization-improvements/40208.
User flow is here - https://www.figma.com/file/KFi9hIQdrRgo0rLqIC7Sg8/ODK-user-flows?node-id=487%3A20892&t=SoSD4aJLJLL3Kipd-1. The exact layout will be different as we're not doing the "summary" on the end page yet, we can play with whatever feels right in PR review.
The text was updated successfully, but these errors were encountered: