Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include "finalize all drafts" setting in migration of old "mark form as finalized" #5788

Closed
lognaturel opened this issue Oct 20, 2023 · 1 comment · Fixed by #5795
Closed
Assignees
Milestone

Comments

@lognaturel
Copy link
Member

From @dbemke in #5776 (comment)

Old QR codes may have the old "mark form as finalized" admin setting. That setting was migrated to show/hide finalize and save as draft buttons on the form end screen. Now the finalize setting was migrated again so that introducing the "finalize all drafts" setting doesn't add a path to finalize for existing configurations. We should migrate the original "mark form as finalized" admin setting to match that.

@lognaturel lognaturel added this to the v2023.3 milestone Oct 20, 2023
@github-project-automation github-project-automation bot moved this to not ready in ODK Collect Oct 20, 2023
@seadowg seadowg moved this from not ready to backlog in ODK Collect Oct 24, 2023
@seadowg seadowg self-assigned this Oct 24, 2023
@seadowg seadowg moved this from backlog to in progress in ODK Collect Oct 24, 2023
@seadowg seadowg linked a pull request Oct 24, 2023 that will close this issue
5 tasks
@seadowg
Copy link
Member

seadowg commented Oct 25, 2023

Just to clarify what @lognaturel is saying here (correct me if I'm wrong): if "default to finalized" is false and "mark as finalized" is hidden in old settings and they're migrated (via an import or an upgrade) the "Finalize all drafts" should be hidden.

@github-project-automation github-project-automation bot moved this from in progress to done in ODK Collect Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants