Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in the Nested repeats for audit form while removing an empty inner repeat #6015

Closed
dbemke opened this issue Mar 14, 2024 · 1 comment · Fixed by #6105
Closed

Crash in the Nested repeats for audit form while removing an empty inner repeat #6015

dbemke opened this issue Mar 14, 2024 · 1 comment · Fixed by #6105
Assignees
Milestone

Comments

@dbemke
Copy link

dbemke commented Mar 14, 2024

ODK Collect version

2023.3.1. the store version 2024.1.2, the master version 6c6c19d

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

There is a crash in the 3231 Nested repeats for audit form while removing an empty inner repeat.
 https://console.firebase.google.com/u/1/project/api-project-322300403941/crashlytics/app/a[…]ey=65DB5F0903B2000171A29DE4E04C99F0_1918010274617643865

Steps to reproduce the problem

  1. Open to 3231 Nested repeats for audit form.
    3231nested-repeats-for-audit.xml.txt

  2. Go to the hierarchy view.

  3. Tap the arrow 4 times so that you can see outer repeat1, outer group 1, outer repeat 2.

  4. Tap Outer group 1.

  5. Tap the bin to remove the group (inner repeat 2).

  6. In the dialog (Remove group "null” and all of its sub-groups?) tap "Remove group”.

Expected behavior

The app shouldn’t crash

@github-project-automation github-project-automation bot moved this to not ready in ODK Collect Mar 14, 2024
@seadowg seadowg added this to the v2024.2 milestone Mar 26, 2024
@seadowg seadowg moved this from not ready to ready in ODK Collect Mar 26, 2024
@grzesiek2010 grzesiek2010 self-assigned this Apr 22, 2024
@grzesiek2010 grzesiek2010 moved this from ready to in progress in ODK Collect Apr 22, 2024
@grzesiek2010
Copy link
Member

The described section contains a repeatable (inner group) group that is wrapped into a regular group (outer group) so there are no nested repeats there.
The outer group is not repeatable so it shouldn't be even possible to try to remove it. It looks like we mistakenly treat that group as a repeatable one. Here is a much simpler form that reproduces the issue as well:
groups_crash.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants