Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send submissions in oldest first order #6128

Closed
3 tasks done
Tracked by #5991
seadowg opened this issue May 7, 2024 · 3 comments · Fixed by #6356
Closed
3 tasks done
Tracked by #5991

Send submissions in oldest first order #6128

seadowg opened this issue May 7, 2024 · 3 comments · Fixed by #6356
Assignees
Milestone

Comments

@seadowg
Copy link
Member

seadowg commented May 7, 2024

Collect should always send submissions in oldest to newest (in terms of finalization date). This will limit the number of out of order entity updates that servers will have to deal with.

Currently, submissions are either sent in display order (for manual sending) and database order (for auto send).

We should make sure we use oldest to newest order for these operations:

  • Auto sending forms
  • Bulk finalising drafts
  • Manually sending a selected set of forms

They don't all need to be fixed in one PR (or even released at the same time).

@seadowg seadowg mentioned this issue May 7, 2024
24 tasks
@seadowg seadowg changed the title Send submissions in oldest first order (to minimise out of order updates on server) Send submissions in oldest first order May 7, 2024
@seadowg seadowg added this to the v2024.3 milestone May 7, 2024
@seadowg
Copy link
Member Author

seadowg commented May 21, 2024

@lognaturel I've added bulk finalisation here as we could end up auto sending in the wrong order if we bulk finalize in the wrong order in cases where the sending happens very quickly (i.e. we get spin up multiple auto send tasks).

@lognaturel
Copy link
Member

@grzesiek2010 I think you're going to take this one on, right? Would be good to prioritize it so we can test it along with some of the other interesting offline Entities cases. Thanks!

@grzesiek2010
Copy link
Member

Would be good to prioritize it so we can test it along with some of the other interesting offline Entities cases. Thanks!

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants