Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A form is finalized (not sent) if there is "default" auto send setting in the form #6203

Closed
dbemke opened this issue Jun 17, 2024 · 6 comments · Fixed by #6213
Closed

A form is finalized (not sent) if there is "default" auto send setting in the form #6203

dbemke opened this issue Jun 17, 2024 · 6 comments · Fixed by #6213
Assignees
Milestone

Comments

@dbemke
Copy link

dbemke commented Jun 17, 2024

ODK Collect version

the master version fb11c14

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

A form is finalized (appears in "Ready to send”- isn’t sent automatically) if in the form settings there is "default” in auto send options.
(The issue doesn’t occur in the store version 2024.1.3)

Steps to reproduce the problem

  1. In the project there is "wifi or cellular” auto send setting and there is a sim card and wifi on.
  2. Open the form and send it.
    AutoSendDefault.xlsx.txt
  3. Check the "Ready to send” list.

Expected behavior

I couldn’t find information in the documentation about using "default” in auto send setting in a form but in the past the setting sent the form.

@dbemke
Copy link
Author

dbemke commented Jun 17, 2024

The same issue occurs in a form in which auto send is set to "1".
my-form(3).xlsx.txt

@seadowg seadowg moved this from not ready to ready in ODK Collect Jun 18, 2024
@seadowg seadowg added this to the v2024.2 milestone Jun 18, 2024
@seadowg seadowg moved this from ready to in progress in ODK Collect Jun 19, 2024
@seadowg seadowg self-assigned this Jun 19, 2024
@seadowg
Copy link
Member

seadowg commented Jun 19, 2024

  1. In the project there is "wifi or cellular” auto send setting and there is a sim card and wifi on.
  2. Open the form and send it.
    AutoSendDefault.xlsx.txt
  3. Check the "Ready to send” list.

@dbemke it makes sense that we'd send the form in this scenario (we shouldn't treat "default" as "false"), but what happens in older versions when I disable auto send at a settings level with that form? Does it send because it treats "default" (or the "1" in the other example) as "true"?

@dbemke
Copy link
Author

dbemke commented Jun 19, 2024

In the store version in form settings auto send:

  • default - send button at the end page of a form, form is sent automatically
  • false - finalize button at the end page, the form is finalized
  • true- send button at the end page of a form, form is sent automatically

Currently default - send button at the end page, the form isn't sent automatically
So in the past default acted like true but how it the code works I don't know.

@seadowg
Copy link
Member

seadowg commented Jun 19, 2024

What about if auto send is disabled in Collect? In those cases "default" is behaving like there's no auto-send attribute. "true" only matters if the auto send setting is disabled.

@dbemke
Copy link
Author

dbemke commented Jun 19, 2024

If in Collect settings there is auto send set to "off" then with default in form settings the form is finalized (in the store version)

@seadowg
Copy link
Member

seadowg commented Jun 19, 2024

Cool! So with auto-send it does actually behave as the specs say, but with one exception/caveat: unsupported values (like "default" or "muffin") will be treated as if there was no auto-send attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

2 participants