You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The progress indicator is missing while adding offline layers if there's the "don't keep activities" setting enabled. For a moment it looks as if the list of offline layers to add is empty (especially if there are many offline layers to add).
Steps to reproduce the problem
Set "don’t keep activities” in the device.
Go to any form with maps and open the map.
Tap the offline layers icon, "add layers” and select some layers to add.
While on "Add layers” check the list of layers to add and the progress indicator.
Expected behavior
The progress indicator should appear.
Notes
It looks like this is because we use one LiveData to represent "loading" for OfflineMapLayersViewModel and when the Activity is recreated loadExistingLayers finishes quickly and sets isLoading to false. We can either split out two progress states, or use TrackableWorker and modify it to count work in progress rather just being on/off.
The text was updated successfully, but these errors were encountered:
ODK Collect version
the master version 7d30e18
Android version
10, 14
Device used
Redmi 9T, Pixel 7a
Problem description
The progress indicator is missing while adding offline layers if there's the "don't keep activities" setting enabled. For a moment it looks as if the list of offline layers to add is empty (especially if there are many offline layers to add).
Steps to reproduce the problem
Expected behavior
The progress indicator should appear.
Notes
It looks like this is because we use one
LiveData
to represent "loading" forOfflineMapLayersViewModel
and when the Activity is recreatedloadExistingLayers
finishes quickly and setsisLoading
to false. We can either split out two progress states, or useTrackableWorker
and modify it to count work in progress rather just being on/off.The text was updated successfully, but these errors were encountered: