Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing progress indicator while adding offline layers with "don't keep activities" #6221

Closed
dbemke opened this issue Jun 21, 2024 · 0 comments · Fixed by #6235
Closed

Missing progress indicator while adding offline layers with "don't keep activities" #6221

dbemke opened this issue Jun 21, 2024 · 0 comments · Fixed by #6235
Assignees
Milestone

Comments

@dbemke
Copy link

dbemke commented Jun 21, 2024

ODK Collect version

the master version 7d30e18

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

The progress indicator is missing while adding offline layers if there's the "don't keep activities" setting enabled. For a moment it looks as if the list of offline layers to add is empty (especially if there are many offline layers to add).

Steps to reproduce the problem

  1. Set "don’t keep activities” in the device.
  2. Go to any form with maps and open the map.
  3. Tap the offline layers icon, "add layers” and select some layers to add.
  4. While on "Add layers” check the list of layers to add and the progress indicator.

Expected behavior

The progress indicator should appear.

Notes

It looks like this is because we use one LiveData to represent "loading" for OfflineMapLayersViewModel and when the Activity is recreated loadExistingLayers finishes quickly and sets isLoading to false. We can either split out two progress states, or use TrackableWorker and modify it to count work in progress rather just being on/off.

@github-project-automation github-project-automation bot moved this to not ready in ODK Collect Jun 21, 2024
@seadowg seadowg moved this from not ready to ready in ODK Collect Jun 24, 2024
@seadowg seadowg added this to the v2024.2.x milestone Jun 24, 2024
@grzesiek2010 grzesiek2010 self-assigned this Jun 26, 2024
@grzesiek2010 grzesiek2010 moved this from ready to in progress in ODK Collect Jun 26, 2024
@github-project-automation github-project-automation bot moved this from in progress to done in ODK Collect Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants