-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe and document which expressions are evaluated when #516
Comments
@lognaturel affirms that "I believe Gareth had found something in the XForms spec that suggested that expressions should be evaluated regardless of relevance. This has performance implications, certainly.". @tiritea, could you provide more info regarding this? |
found it, in https://www.w3.org/TR/2012/WD-xforms20-20120807/: [emphasis added]
note emphasis that is about visibility in UI... And later:
Which I interpret to mean calculations - as a non-UI element - are specifically not disabled (ie are "not made non-operable") as a consequence of their immediate (or inherited) relevance evaluating to false. More specifically, calculations in non-relevant groups are still to be evaluated. |
Thanks, @tiritea. I think you're right and we should always compute calculates. It's clear to me now that the relevance of a field is a UI concern. What do you think, @lognaturel? If we all agree on this, we should raise an issue and review this accordingly, starting from describing different regression scenarios and creating tests for them. |
FYI adding this as it appears 'relevant' to discussion (no pun intended... ;-) : |
Btw, the practical benefit of always performing calculations irrespective of relevance is that it permits processing lists using repeat groups, but ‘hiding’ the repeat group from the UI so the user doesn’t have to nav thru it; eg my geofence or geotrace-2-KML forms. |
Thanks for taking the time to add info, @tiritea! |
During #515, we detected a special scenario where a group's relevance might make some field calculations not be evaluated. See
Safe2014DagImplTest.verify_relation_between_calculate_expressions_and_relevancy_conditions()
for context.We should discuss this and:
The text was updated successfully, but these errors were encountered: